Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit acd56150 authored by Dan Stoza's avatar Dan Stoza
Browse files

libgui: Remove custom BufferQueue allocators 

Removes the ability to set a custom GraphicBuffer allocator for a
BufferQueue. Custom-allocated buffers may still be used through the
attachBuffer call.

Change-Id: I127bdfb496fc089a61c7e266c8bd2b906d41f32e
parent 3bb0c881

cmds/flatland/GLHelper.cpp

+1 −2
Original line number Diff line number Diff line
@@ -25,7 +25,6 @@ 
 namespace android {



GLHelper::GLHelper() :

    mGraphicBufferAlloc(new GraphicBufferAlloc()),

    mDisplay(EGL_NO_DISPLAY),

    mContext(EGL_NO_CONTEXT),

    mDummySurface(EGL_NO_SURFACE),
@@ -203,7 +202,7 @@ bool GLHelper::createNamedSurfaceTexture(GLuint name, uint32_t w, uint32_t h, 
        sp<GLConsumer>* glConsumer, EGLSurface* surface) {

    sp<IGraphicBufferProducer> producer;

    sp<IGraphicBufferConsumer> consumer;

    BufferQueue::createBufferQueue(&producer, &consumer, mGraphicBufferAlloc);

    BufferQueue::createBufferQueue(&producer, &consumer);

    sp<GLConsumer> glc = new GLConsumer(consumer, name,

            GL_TEXTURE_EXTERNAL_OES, false, true);

    glc->setDefaultBufferSize(w, h);

cmds/flatland/GLHelper.h

+0 −3
Original line number Diff line number Diff line
@@ -14,7 +14,6 @@ 
 * limitations under the License.

 */



#include <gui/GraphicBufferAlloc.h>

#include <gui/GLConsumer.h>

#include <gui/Surface.h>

#include <gui/SurfaceControl.h>
@@ -75,8 +74,6 @@ private: 


    bool setUpShaders(const ShaderDesc* shaderDescs, size_t numShaders);



    sp<GraphicBufferAlloc> mGraphicBufferAlloc;



    EGLDisplay mDisplay;

    EGLContext mContext;

    EGLSurface mDummySurface;

include/gui/BufferQueue.h

+1 −2
Original line number Diff line number Diff line
@@ -76,8 +76,7 @@ public: 
    // producers and consumers. allocator is used to allocate all the

    // needed gralloc buffers.

    static void createBufferQueue(sp<IGraphicBufferProducer>* outProducer,

            sp<IGraphicBufferConsumer>* outConsumer,

            const sp<IGraphicBufferAlloc>& allocator = NULL);

            sp<IGraphicBufferConsumer>* outConsumer);



private:

    BufferQueue(); // Create through createBufferQueue

include/gui/BufferQueueCore.h

+1 −1
Original line number Diff line number Diff line
@@ -75,7 +75,7 @@ public: 
    // BufferQueueCore manages a pool of gralloc memory slots to be used by

    // producers and consumers. allocator is used to allocate all the needed

    // gralloc buffers.

    BufferQueueCore(const sp<IGraphicBufferAlloc>& allocator = NULL);

    BufferQueueCore();

    virtual ~BufferQueueCore();



private:

libs/gui/BufferQueue.cpp

+2 −3
Original line number Diff line number Diff line
@@ -62,14 +62,13 @@ void BufferQueue::ProxyConsumerListener::onSidebandStreamChanged() { 
}



void BufferQueue::createBufferQueue(sp<IGraphicBufferProducer>* outProducer,

        sp<IGraphicBufferConsumer>* outConsumer,

        const sp<IGraphicBufferAlloc>& allocator) {

        sp<IGraphicBufferConsumer>* outConsumer) {

    LOG_ALWAYS_FATAL_IF(outProducer == NULL,

            "BufferQueue: outProducer must not be NULL");

    LOG_ALWAYS_FATAL_IF(outConsumer == NULL,

            "BufferQueue: outConsumer must not be NULL");



    sp<BufferQueueCore> core(new BufferQueueCore(allocator));

    sp<BufferQueueCore> core(new BufferQueueCore());

    LOG_ALWAYS_FATAL_IF(core == NULL,

            "BufferQueue: failed to create BufferQueueCore");