Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9dce90f3 authored by Yi Kong's avatar Yi Kong
Browse files

Remove unnecessary std::move 

Moving a temporary object prevents copy elision, and could reduce
performance.

This fixes -Wpessimizing-move compiler warning.

Test: presubmit
Bug: 154270751
Flag: EXEMPT code cleanup
Change-Id: Ib727d96f45f8d17557c7714599fd07d9993236c3
parent 912ff82e

libs/sensor/SensorManager.cpp

+1 −1
Original line number Diff line number Diff line
@@ -84,7 +84,7 @@ bool findSensorNameInList(int32_t handle, const Vector<Sensor>& sensorList, 
            std::ostringstream oss;

            oss << sensor.getStringType() << ":" << sensor.getName();

            if (outString) {

                *outString = std::move(oss.str());

                *outString = oss.str();

            }

            return true;

        }

services/surfaceflinger/CompositionEngine/src/Output.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1101,10 +1101,10 @@ void Output::prepareFrame() { 
}



ftl::Future<std::monostate> Output::presentFrameAndReleaseLayersAsync(bool flushEvenWhenDisabled) {

    return ftl::Future<bool>(std::move(mHwComposerAsyncWorker->send([this, flushEvenWhenDisabled]() {

    return ftl::Future<bool>(mHwComposerAsyncWorker->send([this, flushEvenWhenDisabled]() {

               presentFrameAndReleaseLayers(flushEvenWhenDisabled);

               return true;

           })))

           }))

            .then([](bool) { return std::monostate{}; });

}