Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9abda97e authored by Cairn Overturf's avatar Cairn Overturf Committed by Android (Google) Code Review
Browse files

Revert "Don't force client composition when rounded corners are cached" 

This reverts commit c7e3e0c1.

Reason for revert: b/398131325

Change-Id: I5870678cb8a69457e0a4a197a8cb67128e104399
parent c7e3e0c1

services/surfaceflinger/CompositionEngine/include/compositionengine/impl/OutputLayer.h

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ private: 
    void detectDisallowedCompositionTypeChange(

            aidl::android::hardware::graphics::composer3::Composition from,

            aidl::android::hardware::graphics::composer3::Composition to) const;

    bool isClientCompositionForced(bool isPeekingThrough, bool isCached) const;

    bool isClientCompositionForced(bool isPeekingThrough) const;

    void updateLuts(const LayerFECompositionState&,

                    const std::optional<std::vector<std::optional<LutProperties>>>& properties);

};

services/surfaceflinger/CompositionEngine/src/OutputLayer.cpp

+3 −7
Original line number Diff line number Diff line
@@ -865,8 +865,7 @@ void OutputLayer::writeCompositionTypeToHWC(HWC2::Layer* hwcLayer, 
                                            bool isPeekingThrough, bool skipLayer) {

    auto& outputDependentState = editState();



    bool isCached = !skipLayer && outputDependentState.overrideInfo.buffer;

    if (isClientCompositionForced(isPeekingThrough, isCached)) {

    if (isClientCompositionForced(isPeekingThrough)) {

        // If we are forcing client composition, we need to tell the HWC

        requestedCompositionType = Composition::CLIENT;

    }
@@ -956,12 +955,9 @@ void OutputLayer::detectDisallowedCompositionTypeChange(Composition from, Compos 
    }

}



bool OutputLayer::isClientCompositionForced(bool isPeekingThrough, bool isCached) const {

    // If this layer was flattened into a CachedSet then it is not necessary for

    // the GPU to compose it.

    bool requiresClientDrawnRoundedCorners = !isCached && getLayerFE().hasRoundedCorners();

bool OutputLayer::isClientCompositionForced(bool isPeekingThrough) const {

    return getState().forceClientComposition ||

            (!isPeekingThrough && requiresClientDrawnRoundedCorners);

            (!isPeekingThrough && getLayerFE().hasRoundedCorners());

}



void OutputLayer::applyDeviceCompositionTypeChange(Composition compositionType) {

services/surfaceflinger/FrontEnd/LayerSnapshot.cpp

+2 −2
Original line number Diff line number Diff line
@@ -544,7 +544,7 @@ char LayerSnapshot::classifyCompositionForDebug( 
        case Composition::INVALID:

            return 'i';

        case Composition::SOLID_COLOR:

            return 'e';

            return 'c';

        case Composition::CURSOR:

            return 'u';

        case Composition::SIDEBAND:
@@ -552,7 +552,7 @@ char LayerSnapshot::classifyCompositionForDebug( 
        case Composition::DISPLAY_DECORATION:

            return 'a';

        case Composition::REFRESH_RATE_INDICATOR:

            return 'f';

            return 'r';

        case Composition::CLIENT:

        case Composition::DEVICE:

            break;