Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 982fcbbf authored by Alec Mouri's avatar Alec Mouri
Browse files

Add some flags for readback 

* Aconfig flag for the rollout
* Debug sysprop for configuring a device, since some devices won't be
  able to productionize readback at all.

Bug: 384816457
Flag: com.android.graphics.surfaceflinger.flags.readback_screenshot
Test: builds
Change-Id: I41ff3fe3d00dc93cc16ef8d1bc9e9ad1a392dcde
parent f423c74b

services/surfaceflinger/common/FlagManager.cpp

+4 −0
Original line number Diff line number Diff line
@@ -117,6 +117,7 @@ void FlagManager::dump(std::string& result) const { 
    DUMP_SYSPROP_FLAG(disable_sched_fifo_re);

    DUMP_SYSPROP_FLAG(disable_sched_fifo_composer);

    DUMP_SYSPROP_FLAG(disable_sched_fifo_composer_callback);

    DUMP_SYSPROP_FLAG(productionize_readback_screenshot);



    /// Legacy server flags ///

    DUMP_LEGACY_SERVER_FLAG(use_adpf_cpu_hint);
@@ -131,6 +132,7 @@ void FlagManager::dump(std::string& result) const { 
    DUMP_ACONFIG_FLAG(graphite_renderengine_preview_rollout);

    DUMP_ACONFIG_FLAG(increase_missed_frame_jank_threshold);

    DUMP_ACONFIG_FLAG(monitor_buffer_fences);

    DUMP_ACONFIG_FLAG(readback_screenshot);

    DUMP_ACONFIG_FLAG(refresh_rate_overlay_on_external_display);

    DUMP_ACONFIG_FLAG(vsync_predictor_rate_change_with_aligned_sequence);

    DUMP_ACONFIG_FLAG(vsync_predictor_recovery);
@@ -237,6 +239,7 @@ FLAG_MANAGER_SYSPROP_FLAG(disable_sched_fifo_sf_sched, /* default */ false) 
FLAG_MANAGER_SYSPROP_FLAG(disable_sched_fifo_re, /* default */ false)

FLAG_MANAGER_SYSPROP_FLAG(disable_sched_fifo_composer, /* default */ false)

FLAG_MANAGER_SYSPROP_FLAG(disable_sched_fifo_composer_callback, /* default */ false)

FLAG_MANAGER_SYSPROP_FLAG(productionize_readback_screenshot, /* default */ false)



/// Legacy server flags ///

FLAG_MANAGER_LEGACY_SERVER_FLAG(test_flag, "", "")
@@ -296,6 +299,7 @@ FLAG_MANAGER_ACONFIG_FLAG(adpf_native_session_manager, ""); 
FLAG_MANAGER_ACONFIG_FLAG(graphite_renderengine_preview_rollout, "");

FLAG_MANAGER_ACONFIG_FLAG(increase_missed_frame_jank_threshold, "");

FLAG_MANAGER_ACONFIG_FLAG(monitor_buffer_fences, "");

FLAG_MANAGER_ACONFIG_FLAG(readback_screenshot, "")

FLAG_MANAGER_ACONFIG_FLAG(vsync_predictor_rate_change_with_aligned_sequence, "")

FLAG_MANAGER_ACONFIG_FLAG(vsync_predictor_recovery, "");

services/surfaceflinger/common/include/common/FlagManager.h

+2 −0
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ public: 
    bool disable_sched_fifo_re() const;

    bool disable_sched_fifo_composer() const;

    bool disable_sched_fifo_composer_callback() const;

    bool productionize_readback_screenshot() const;



    /// Legacy server flags ///

    bool test_flag() const;
@@ -65,6 +66,7 @@ public: 
    bool graphite_renderengine_preview_rollout() const;

    bool increase_missed_frame_jank_threshold() const;

    bool monitor_buffer_fences() const;

    bool readback_screenshot() const;

    bool refresh_rate_overlay_on_external_display() const;

    bool vsync_predictor_rate_change_with_aligned_sequence() const;

    bool vsync_predictor_recovery() const;

services/surfaceflinger/surfaceflinger_flags_new.aconfig

+7 −0
Original line number Diff line number Diff line
@@ -235,6 +235,13 @@ flag { 
  bug: "374072507"

} # pacesetter_selection



flag {

  name: "readback_screenshot"

  namespace: "core_graphics"

  description: "Allows devices to use DPU readback for fullscreen screenshots"

  bug: "384816457"

} # readback_screenshot



flag {

  name: "skip_invisible_windows_in_input"

  namespace: "window_surfaces"