Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 97fe7cda authored by Devin Moore's avatar Devin Moore
Browse files

Remove ARpcDoubleRemoveProvider test because UB 

This is undefined behavior (use-after-free) because the
ABinderRpc_AccessorProvider is deleted with the first call
to ABinderRpc_unregisterAccessorProvider!

Test: none
Bug: 369847529

Change-Id: I71ffe6e87d479ab998a8b1fe14c7f7216024417b
parent 8dd89273

libs/binder/tests/binderRpcTest.cpp

+0 −9
Original line number Diff line number Diff line
@@ -1544,15 +1544,6 @@ TEST_F(BinderARpcNdk, ARpcNoDataNoInfoOnDeleteCallback) { 
    ABinderRpc_Accessor_delete(accessor);

}



TEST_F(BinderARpcNdk, ARpcDoubleRemoveProvider) {

    ABinderRpc_AccessorProvider* provider =

            ABinderRpc_registerAccessorProvider(getAccessor, kARpcSupportedServices,

                                                kARpcNumSupportedServices, nullptr, nullptr);

    ASSERT_NE(nullptr, provider);

    ABinderRpc_unregisterAccessorProvider(provider);

    EXPECT_DEATH(ABinderRpc_unregisterAccessorProvider(provider), " was already unregistered");

}



TEST_F(BinderARpcNdk, ARpcNullArgs_ConnectionInfo_new) {

    sockaddr_storage addr;

    EXPECT_EQ(nullptr, ABinderRpc_ConnectionInfo_new(reinterpret_cast<const sockaddr*>(&addr), 0));