Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8dbf1405 authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

InputTracer: Remove precondition check for FLAG_SECURE 

Do not use LayoutParams's FLAG_SECURE to enforce preconditions on the
input window, because the InputConfigs are processed based on the layer
flags, which may be out of sync with the LayoutParams flag.

Bug: 332616639
Bug: 210460522
Test: None
Change-Id: I890b165d498bc91c68e1149549089b5669eaba57
parent efd55b1a

services/inputflinger/dispatcher/trace/InputTracer.cpp

+0 −7
Original line number Diff line number Diff line
@@ -89,13 +89,6 @@ InputTargetInfo getTargetInfo(const InputTarget& target) { 
    const auto& info = *target.windowHandle->getInfo();

    const bool isSensitiveTarget =

            info.inputConfig.test(gui::WindowInfo::InputConfig::SENSITIVE_FOR_TRACING);



    // All FLAG_SECURE targets must be marked as sensitive for tracing.

    if (info.layoutParamsFlags.test(gui::WindowInfo::Flag::SECURE) && !isSensitiveTarget) {

        LOG(FATAL)

                << "Input target with FLAG_SECURE does not set InputConfig::SENSITIVE_FOR_TRACING: "

                << info;

    }

    return {target.windowHandle->getInfo()->ownerUid, isSensitiveTarget};

}