Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8b555266 authored May 08, 2018 by Dan Willemsen

Remove unused `tags` property from Android.bp files

The tags property is (and has always been) unused by Soong. The property has
been defined as a list of strings, and the `androidmk` converted any
LOCAL_MODULE_TAGS entries over to it, but we've never done anything with it.

In preparation for removing the definition from Soong, I'm removing it from all
Android.bp files in the tree.

Since this has never done anything, this is a no-op, but if you really did want
the Android.mk behavior, the proper way to define a module to be installed in
userdebug / eng builds is to use PRODUCT_PACKAGES_DEBUG or PRODUCT_PACKAGES_ENG
in the appropriate product makefile.

Exempt-From-Owner-Approval: global no-op build change
Test: remove `tags` from Soong, see errors go away.
Change-Id: I48b87d082964d171dffde642805b94d696e228ec
Merged-In: I48b87d082964d171dffde642805b94d696e228ec

parent 2856475f

libs/vr/libbufferhub/Android.bp

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -62,11 +62,9 @@ cc_library {
	}		}

	cc_test {		cc_test {
	tags: ["optional"],
	srcs: ["bufferhub_tests.cpp"],		srcs: ["bufferhub_tests.cpp"],
	static_libs: ["libbufferhub"] + staticLibraries,		static_libs: ["libbufferhub"] + staticLibraries,
	shared_libs: sharedLibraries,		shared_libs: sharedLibraries,
	header_libs: headerLibraries,		header_libs: headerLibraries,
	name: "bufferhub_tests",		name: "bufferhub_tests",
	}		}

libs/vr/libbufferhubqueue/tests/Android.bp

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -37,7 +37,6 @@ cc_test {
	"-Wno-error=sign-compare", // to fix later		"-Wno-error=sign-compare", // to fix later
	],		],
	name: "buffer_hub_queue-test",		name: "buffer_hub_queue-test",
	tags: ["optional"],
	}		}

	cc_test {		cc_test {
	@@ -54,5 +53,4 @@ cc_test {
	"-Werror",		"-Werror",
	],		],
	name: "buffer_hub_queue_producer-test",		name: "buffer_hub_queue_producer-test",
	tags: ["optional"],
	}		}

libs/vr/libdisplay/Android.bp

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -50,7 +50,6 @@ headerLibraries = [
	]		]

	cc_library {		cc_library {
	tags: ["tests"],
	srcs: sourceFiles,		srcs: sourceFiles,
	cflags: ["-DLOG_TAG=\"libdisplay\"",		cflags: ["-DLOG_TAG=\"libdisplay\"",
	"-DTRACE=0",		"-DTRACE=0",

libs/vr/libdvrcommon/Android.bp

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -58,7 +58,6 @@ testFiles = [

	cc_test {		cc_test {
	name: "libdvrcommon_test",		name: "libdvrcommon_test",
	tags: ["optional"],

	srcs: testFiles,		srcs: testFiles,
	cflags: [		cflags: [

services/surfaceflinger/tests/fakehwc/Android.bp

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -30,6 +30,5 @@ cc_test {
	"libtrace_proto",		"libtrace_proto",
	"libgmock"		"libgmock"
	],		],
	tags: ["tests"],
	test_suites: ["device-tests"]		test_suites: ["device-tests"]
	}		}
	No newline at end of file