Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8378013d authored by Tomasz Wasilczyk's avatar Tomasz Wasilczyk
Browse files

Minor build-outside-android fixes 

- add missing includes
- fix maybe_unused warning
- use LOG_ALWAYS_FATAL instead of __assert (behind flag)

Bug: 302723053
Test: mma in binder folder
Change-Id: I4e90ff7c7f37e6736bc38abaa11744ccf7155a17
parent dec4e24b

libs/binder/Android.bp

+12 −9
Original line number Diff line number Diff line
@@ -106,6 +106,17 @@ cc_defaults { 
    header_libs: [

        "libbinder_headers",

    ],



    cflags: [

        "-Wextra",

        "-Wextra-semi",

        "-Werror",

        "-Wzero-as-null-pointer-constant",

        "-Wreorder-init-list",

        "-Wunused-const-variable",

        "-DANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION",

        "-DANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION",

    ],

}



cc_defaults {
@@ -135,15 +146,6 @@ cc_defaults { 
        export_aidl_headers: true,

    },



    cflags: [

        "-Wextra",

        "-Wextra-semi",

        "-Werror",

        "-Wzero-as-null-pointer-constant",

        "-Wreorder-init-list",

        "-DANDROID_BASE_UNIQUE_FD_DISABLE_IMPLICIT_CONVERSION",

        "-DANDROID_UTILS_REF_BASE_DISABLE_IMPLICIT_CONSTRUCTION",

    ],

    product_variables: {

        debuggable: {

            cflags: [
@@ -220,6 +222,7 @@ cc_defaults { 


    cflags: [

        "-DBINDER_RPC_SINGLE_THREADED",

        "-DBINDER_ENABLE_LIBLOG_ASSERT",

        // Trusty libbinder uses vendor stability for its binders

        "-D__ANDROID_VNDK__",

        "-U__ANDROID__",

libs/binder/Parcel.cpp

+1 −1
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ static std::atomic<size_t> gParcelGlobalAllocSize; 
constexpr size_t kMaxFds = 1024;



// Maximum size of a blob to transfer in-place.

static const size_t BLOB_INPLACE_LIMIT = 16 * 1024;

[[maybe_unused]] static const size_t BLOB_INPLACE_LIMIT = 16 * 1024;



enum {

    BLOB_INPLACE = 0,

libs/binder/file.cpp

+2 −0
Original line number Diff line number Diff line
@@ -18,6 +18,8 @@ 


#ifdef BINDER_NO_LIBBASE



#include "Utils.h"



#include <stdint.h>



// clang-format off

libs/binder/include/binder/Delegate.h

+5 −0
Original line number Diff line number Diff line
@@ -18,6 +18,11 @@ 


#include <binder/IBinder.h>



#if !defined(__BIONIC__) && defined(BINDER_ENABLE_LIBLOG_ASSERT)

#include <log/log.h>

#define __assert(file, line, message) LOG_ALWAYS_FATAL(file ":" #line ": " message)

#endif



#ifndef __BIONIC__

#ifndef __assert

libs/binder/ndk/include_ndk/android/binder_status.h

+5 −0
Original line number Diff line number Diff line
@@ -31,6 +31,11 @@ 
#include <stdint.h>

#include <sys/cdefs.h>



#if !defined(__BIONIC__) && defined(BINDER_ENABLE_LIBLOG_ASSERT)

#include <log/log.h>

#define __assert(file, line, message) LOG_ALWAYS_FATAL(file ":" #line ": " message)

#endif



__BEGIN_DECLS



#ifndef __BIONIC__