Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 82d07c9e authored by Robert Carr's avatar Robert Carr
Browse files

BBQSurface: Give client a chance to observe transform hint earlier 

The client may be observing the transform hint through the Surface.cpp
codepath however Surface#mTransformHint will only be updated on
queueBuffer. However imagine a scenario like this:
	1. transform hint changes on server
	2. queue buffer
	2. repeat queue buffer
	3. callback for queue buffer 1 and 2, updates transform hint on
	client
	4. queue buffer 4
	5. Client now observes transform hint
	6. Queue buffer 5(!) will finally contain the transform hint.

With this change we give the client a chance to observe the tranform
hint in this scenario before queue buffer 4. In the case of the
ScreenDecorOverlay's which rarely redraw, this seems to fix some
persistent pre-rotation issues.

Bug: 184842607
Test: Existing tests pass.
Change-Id: I34524ee40c6076f497bb0c60af901e9c93798a48
parent 272e1621

libs/gui/BLASTBufferQueue.cpp

+21 −0
Original line number Diff line number Diff line
@@ -316,6 +316,11 @@ void BLASTBufferQueue::releaseBufferCallback(uint64_t graphicBufferId, 
    std::unique_lock _lock{mMutex};

    BQA_LOGV("releaseBufferCallback graphicBufferId=%" PRIu64, graphicBufferId);



    if (mSurfaceControl != nullptr) {

        mTransformHint = mSurfaceControl->getTransformHint();

        mBufferItemConsumer->setTransformHint(mTransformHint);

    }



    auto it = mSubmitted.find(graphicBufferId);

    if (it == mSubmitted.end()) {

        BQA_LOGE("ERROR: releaseBufferCallback without corresponding submitted buffer %" PRIu64,
@@ -608,6 +613,14 @@ public: 
    status_t setFrameTimelineInfo(const FrameTimelineInfo& frameTimelineInfo) override {

        return mBbq->setFrameTimelineInfo(frameTimelineInfo);

    }

 protected:

    uint32_t getTransformHint() const override {

        if (mStickyTransform == 0 && !transformToDisplayInverse()) {

            return mBbq->getLastTransformHint();

        } else {

            return 0;

        }

    }

};



// TODO: Can we coalesce this with frame updates? Need to confirm
@@ -777,4 +790,12 @@ PixelFormat BLASTBufferQueue::convertBufferFormat(PixelFormat& format) { 
    return convertedFormat;

}



uint32_t BLASTBufferQueue::getLastTransformHint() const {

    if (mSurfaceControl != nullptr) {

        return mSurfaceControl->getTransformHint();

    } else {

        return 0;

    }

}



} // namespace android

libs/gui/Surface.cpp

+2 −2
Original line number Diff line number Diff line
@@ -1288,7 +1288,7 @@ int Surface::query(int what, int* value) const { 
                        mUserHeight ? mUserHeight : mDefaultHeight);

                return NO_ERROR;

            case NATIVE_WINDOW_TRANSFORM_HINT:

                *value = static_cast<int>(mTransformHint);

                *value = static_cast<int>(getTransformHint());

                return NO_ERROR;

            case NATIVE_WINDOW_CONSUMER_RUNNING_BEHIND: {

                status_t err = NO_ERROR;
@@ -1822,7 +1822,7 @@ int Surface::dispatchGetExtraBufferCount(va_list args) { 
    return getExtraBufferCount(extraBuffers);

}



bool Surface::transformToDisplayInverse() {

bool Surface::transformToDisplayInverse() const {

    return (mTransform & NATIVE_WINDOW_TRANSFORM_INVERSE_DISPLAY) ==

            NATIVE_WINDOW_TRANSFORM_INVERSE_DISPLAY;

}

libs/gui/include/gui/BLASTBufferQueue.h

+2 −0
Original line number Diff line number Diff line
@@ -103,6 +103,8 @@ public: 


    void setSidebandStream(const sp<NativeHandle>& stream);



    uint32_t getLastTransformHint() const;



    virtual ~BLASTBufferQueue();



private:

libs/gui/include/gui/Surface.h

+2 −1
Original line number Diff line number Diff line
@@ -278,7 +278,6 @@ private: 
    int dispatchGetLastQueuedBuffer(va_list args);

    int dispatchSetFrameTimelineInfo(va_list args);

    int dispatchGetExtraBufferCount(va_list args);

    bool transformToDisplayInverse();



protected:

    virtual int dequeueBuffer(ANativeWindowBuffer** buffer, int* fenceFd);
@@ -490,6 +489,8 @@ protected: 
    // mTransformHint is the transform probably applied to buffers of this

    // window. this is only a hint, actual transform may differ.

    uint32_t mTransformHint;

    virtual uint32_t getTransformHint() const { return mTransformHint; }

    bool transformToDisplayInverse() const;



    // mProducerControlledByApp whether this buffer producer is controlled

    // by the application