Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 80afc6f3 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: remove Parcel::remove 

Never should be called or implemented. Currently is an alias for abort.

Bug: N/A
Test: N/A
Change-Id: I3dba64b665b4f6d15eb18a750763ba2cfb9ec720
parent 2fee0951

libs/binder/IPCThreadState.cpp

+1 −1
Original line number Original line Diff line number Diff line
@@ -953,7 +953,7 @@ status_t IPCThreadState::talkWithDriver(bool doReceive) 
    if (err >= NO_ERROR) {

    if (err >= NO_ERROR) {

        if (bwr.write_consumed > 0) {

        if (bwr.write_consumed > 0) {

            if (bwr.write_consumed < mOut.dataSize())

            if (bwr.write_consumed < mOut.dataSize())

                mOut.remove(0, bwr.write_consumed);

                LOG_ALWAYS_FATAL("Driver did not consume write buffer");

            else {

            else {

                mOut.setDataSize(0);

                mOut.setDataSize(0);

                processPostWriteDerefs();

                processPostWriteDerefs();

libs/binder/Parcel.cpp

+0 −5
Original line number Original line Diff line number Diff line
@@ -1345,11 +1345,6 @@ status_t Parcel::writeNoException() 
    return status.writeToParcel(this);

    return status.writeToParcel(this);

}

}





void Parcel::remove(size_t /*start*/, size_t /*amt*/)

{

    LOG_ALWAYS_FATAL("Parcel::remove() not yet implemented!");

}



status_t Parcel::validateReadData(size_t upperBound) const

status_t Parcel::validateReadData(size_t upperBound) const

{

{

    // Don't allow non-object reads on object data

    // Don't allow non-object reads on object data

libs/binder/include/binder/Parcel.h

+0 −2
Original line number Original line Diff line number Diff line
@@ -238,8 +238,6 @@ public: 
    // stack gathering and serialization that the Java implementation does.

    // stack gathering and serialization that the Java implementation does.

    status_t            writeNoException();

    status_t            writeNoException();

    

    

    void                remove(size_t start, size_t amt);

    

    status_t            read(void* outData, size_t len) const;

    status_t            read(void* outData, size_t len) const;

    const void*         readInplace(size_t len) const;

    const void*         readInplace(size_t len) const;

    int32_t             readInt32() const;

    int32_t             readInt32() const;