Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7bdcceb5 authored by Leon Scroggins III's avatar Leon Scroggins III
Browse files

Update IfExepensiveOutputDataspaceIsUsed test 

Prior to I5c77769cf9fd2f07806c97022fa4bb940bfcc1ac, using a P3 output
space meant we would boost the GPU frequency. This was a shortcut for
having a different dataspace, since it would require more GPU work. The
more thorough check means that we boost only if the inputs don't match
the output. Update the test to include a single layer, which defaults to
a different dataspace, making the test pass again.

Bug: 223651281
Test: libcompositionengine_test
Change-Id: Iad084a8388e6203b83135ebfb632fda1b3cdb448
parent cf17ebca

services/surfaceflinger/CompositionEngine/tests/OutputTest.cpp

+2 −1
Original line number Original line Diff line number Diff line
@@ -3744,8 +3744,9 @@ struct OutputComposeSurfacesTest_SetsExpensiveRendering : public OutputComposeSu 
TEST_F(OutputComposeSurfacesTest_SetsExpensiveRendering, IfExepensiveOutputDataspaceIsUsed) {

TEST_F(OutputComposeSurfacesTest_SetsExpensiveRendering, IfExepensiveOutputDataspaceIsUsed) {

    mOutput.mState.dataspace = kExpensiveOutputDataspace;

    mOutput.mState.dataspace = kExpensiveOutputDataspace;





    LayerFE::LayerSettings layerSettings;

    EXPECT_CALL(mOutput, generateClientCompositionRequests(_, kExpensiveOutputDataspace, _))

    EXPECT_CALL(mOutput, generateClientCompositionRequests(_, kExpensiveOutputDataspace, _))

            .WillOnce(Return(std::vector<LayerFE::LayerSettings>{}));

            .WillOnce(Return(std::vector<LayerFE::LayerSettings>{layerSettings}));





    // For this test, we also check the call order of key functions.

    // For this test, we also check the call order of key functions.

    InSequence seq;

    InSequence seq;