Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78273119 authored by Hashcode's avatar Hashcode Committed by Ricardo Cerqueira
Browse files

sf: Always use opengles for screen capture 

Go back to the usage of GRALLOC_USAGE_HW_TEXTURE and GRALLOC_USAGE_HW_RENDERER
in captureScreenImplLocked regardless of useReadPixels value

This fixes the EGL_NO_IMAGE_KHR error returned from
eglCreateImageKHR (blank images returned from screenshot path)

Change-Id: I62fe90a081607b9e89c67f3dcfd34c84efc89d35
parent 718f3c2e

services/surfaceflinger/SurfaceFlinger.cpp

+2 −4
Original line number Diff line number Diff line
@@ -3132,10 +3132,8 @@ status_t SurfaceFlinger::captureScreenImplLocked( 


    status_t result = NO_ERROR;

    if (native_window_api_connect(window, NATIVE_WINDOW_API_EGL) == NO_ERROR) {

        uint32_t usage = GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN;

        if (!useReadPixels) {

            usage |= GRALLOC_USAGE_HW_RENDER | GRALLOC_USAGE_HW_TEXTURE;

        }

        uint32_t usage = GRALLOC_USAGE_SW_READ_OFTEN | GRALLOC_USAGE_SW_WRITE_OFTEN |

                        GRALLOC_USAGE_HW_RENDER | GRALLOC_USAGE_HW_TEXTURE;



        int err = 0;

        err = native_window_set_buffers_dimensions(window, reqWidth, reqHeight);