Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 765ff80c authored by Devin Moore's avatar Devin Moore
Browse files

Store p.toString() in a string variable in binder_parcel_fuzzer 

So it still gets called when FUZZ_LOG isn't enabled.

Test: binder_parcel_fuzzer
Bug: 2503960
Change-Id: Iad6dba81a399ed77142db932ca0f923948255c6b
parent f7b352ff

libs/binder/tests/parcel_fuzzer/binder.cpp

+2 −1
Original line number Diff line number Diff line
@@ -374,7 +374,8 @@ std::vector<ParcelRead<::android::Parcel>> BINDER_PARCEL_READ_FUNCTIONS { 
        parcelables::GenericDataParcelable genericDataParcelable;

        status_t status = genericDataParcelable.readFromParcel(&p);

        FUZZ_LOG() << " status: " << status;

        FUZZ_LOG() << " toString() result: " << genericDataParcelable.toString();

        std::string toString = genericDataParcelable.toString();

        FUZZ_LOG() << " toString() result: " << toString;

    },

};

// clang-format on

libs/binder/tests/parcel_fuzzer/binder_ndk.cpp

+2 −1
Original line number Diff line number Diff line
@@ -198,7 +198,8 @@ std::vector<ParcelRead<NdkParcelAdapter>> BINDER_NDK_PARCEL_READ_FUNCTIONS{ 
            aidl::parcelables::GenericDataParcelable genericDataParcelable;

            binder_status_t status = genericDataParcelable.readFromParcel(p.aParcel());

            FUZZ_LOG() << "status: " << status;

            FUZZ_LOG() << "toString() result: " << genericDataParcelable.toString();

            std::string toString = genericDataParcelable.toString();

            FUZZ_LOG() << "toString() result: " << toString;

        },

        [](const NdkParcelAdapter& p, FuzzedDataProvider& provider) {

            FUZZ_LOG() << "about to marshal AParcel";