Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 733610f6 authored by Mike McTernan's avatar Mike McTernan
Browse files

Mark the return of munmap() as unused. 

Allow munmap() to be marked with nodiscard / warn_unused_result attribute without causing a warning or error here.

Bug: 361754857
Test: build.py
Change-Id: I49f85c79c8741b28e5baca35431a59288e07d862
parent a3dba622

libs/binder/Parcel.cpp

+6 −2
Original line number Diff line number Diff line
@@ -1725,7 +1725,9 @@ status_t Parcel::writeBlob(size_t len, bool mutableCopy, WritableBlob* outBlob) 
                }

            }

        }

        ::munmap(ptr, len);

        if (::munmap(ptr, len) == -1) {

            ALOGW("munmap() failed: %s", strerror(errno));

        }

    }

    ::close(fd);

    return status;
@@ -3331,7 +3333,9 @@ Parcel::Blob::~Blob() { 


void Parcel::Blob::release() {

    if (mFd != -1 && mData) {

        ::munmap(mData, mSize);

        if (::munmap(mData, mSize) == -1) {

            ALOGW("munmap() failed: %s", strerror(errno));

        }

    }

    clear();

}