Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7323711d authored by Steven Moreland's avatar Steven Moreland
Browse files

RPC Binder: cleaner cast to RpcServer. 

This is one of the things that was confusing me when
I was debugging recent OOM issues.

Bug: 416772676
Test: binderRpcTest
Change-Id: Iebd7815450973512c5059add94ee0e43f6ec9810
parent 54dde948

libs/binder/RpcServer.cpp

+1 −5
Original line number Diff line number Diff line
@@ -535,11 +535,7 @@ void RpcServer::establishConnection( 
                }

            }



            if (!session->setForServer(server,

                                       sp<RpcServer::EventListener>::fromExisting(

                                               static_cast<RpcServer::EventListener*>(

                                                       server.get())),

                                       sessionId, sessionSpecificRoot)) {

            if (!session->setForServer(server, server, sessionId, sessionSpecificRoot)) {

                ALOGE("Failed to attach server to session");

                return;

            }

libs/binder/include/binder/RpcServer.h

+1 −0
Original line number Diff line number Diff line
@@ -249,6 +249,7 @@ public: 
private:

    friend RpcServerTrusty;

    friend sp<RpcServer>;

    friend wp<EventListener>;

    explicit RpcServer(std::unique_ptr<RpcTransportCtx> ctx);



    void onSessionAllIncomingThreadsEnded(const sp<RpcSession>& session) override;