Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7320612a authored by Carmen Jackson's avatar Carmen Jackson
Browse files

atrace: Don't NPE if we can't access hal-related tracepoint files. 

This currently NPEs when Traceur attempts to start a trace.
Based on b/34242478, this is currently expected and we should fail
gracefully instead.

Bug: 37281960

Test: Starting a trace using Traceur on a userdebug build succeeds.

Change-Id: I082d5750625dec0e1db4a1dd341dc332d8dd752f
parent de47fabe

cmds/atrace/atrace.cpp

+6 −0
Original line number Original line Diff line number Diff line
@@ -552,7 +552,13 @@ static void pokeHalServices() 
                // ignore

                // ignore

                continue;

                continue;

            }

            }



            sp<IBase> interface = interfaceRet;

            sp<IBase> interface = interfaceRet;

            if (interface == nullptr) {

                // ignore

                continue;

            }



            auto notifyRet = interface->notifySyspropsChanged();

            auto notifyRet = interface->notifySyspropsChanged();

            if (!notifyRet.isOk()) {

            if (!notifyRet.isOk()) {

                // ignore

                // ignore