Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 71da15ec authored by John Reck's avatar John Reck
Browse files

Adjust SET_DISPLAY_BRIGHTNESS check 

Fixes: 183985553
Test: make & flash
Change-Id: Id0c7d7161d8a583b84a85e619966babd21232686
parent 8827090d

services/surfaceflinger/SurfaceFlinger.cpp

+1 −3
Original line number Original line Diff line number Diff line
@@ -5192,17 +5192,15 @@ status_t SurfaceFlinger::CheckTransactCodeCredentials(uint32_t code) { 
        // captureLayers and captureDisplay will handle the permission check in the function

        // captureLayers and captureDisplay will handle the permission check in the function

        case CAPTURE_LAYERS:

        case CAPTURE_LAYERS:

        case CAPTURE_DISPLAY:

        case CAPTURE_DISPLAY:

        case SET_DISPLAY_BRIGHTNESS:

        case SET_FRAME_TIMELINE_INFO:

        case SET_FRAME_TIMELINE_INFO:

        case GET_GPU_CONTEXT_PRIORITY:

        case GET_GPU_CONTEXT_PRIORITY:

        case GET_EXTRA_BUFFER_COUNT: {

        case GET_EXTRA_BUFFER_COUNT: {

            // This is not sensitive information, so should not require permission control.

            // This is not sensitive information, so should not require permission control.

            return OK;

            return OK;

        }

        }

        case SET_DISPLAY_BRIGHTNESS:

        case ADD_HDR_LAYER_INFO_LISTENER:

        case ADD_HDR_LAYER_INFO_LISTENER:

        case REMOVE_HDR_LAYER_INFO_LISTENER: {

        case REMOVE_HDR_LAYER_INFO_LISTENER: {

            // TODO (b/183985553): Should getting & setting brightness be part of this...?

            // codes that require permission check

            IPCThreadState* ipc = IPCThreadState::self();

            IPCThreadState* ipc = IPCThreadState::self();

            const int pid = ipc->getCallingPid();

            const int pid = ipc->getCallingPid();

            const int uid = ipc->getCallingUid();

            const int uid = ipc->getCallingUid();