Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6da2a955 authored by Steven Moreland's avatar Steven Moreland
Browse files

Binder: extended error includes cmd name string. 

Bug: 425753105
Test: boot, run tests, check logs:
06-20 18:17:19.933  4392  4392 E libbinder.IPCThreadState: Binder
transaction failure. id: 147598, cmd: BR_FROZEN_REPLY (29202), error: 0
(Success)
06-20 18:17:21.875  4392  4392 E libbinder.IPCThreadState: Binder
transaction failure. id: 148377, cmd: BR_FAILED_REPLY (29201), error:
-28 (No space left on device)
Flag: EXEMPT .

Change-Id: Ifb03ce63a6df32e71067aba55d782feac665fb26
parent 8443b19b

libs/binder/IPCThreadState.cpp

+4 −3
Original line number Diff line number Diff line
@@ -133,7 +133,7 @@ static const char* getReturnString(uint32_t cmd) 
    if (idx < sizeof(kReturnStrings) / sizeof(kReturnStrings[0]))

        return kReturnStrings[idx];

    else

        return "unknown";

        return "(BR_* unknown)";

}



static const void* printBinderTransactionData(std::ostream& out, const void* data) {
@@ -1718,8 +1718,9 @@ void IPCThreadState::logExtendedError() { 
    }

#endif



    ALOGE_IF(ee.command != BR_OK, "Binder transaction failure. id: %d, BR_*: %d, error: %d (%s)",

             ee.id, ee.command, ee.param, strerror(-ee.param));

    ALOGE_IF(ee.command != BR_OK,

             "Binder transaction failure. id: %d, cmd: %s (%d), error: %d (%s)", ee.id,

             getReturnString(ee.command), ee.command, ee.param, strerror(-ee.param));

}



void IPCThreadState::freeBuffer(const uint8_t* data, size_t /*dataSize*/,