Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 653078f6 authored by Alex Ray's avatar Alex Ray
Browse files

utils: clarify scoped tracing functionality 

ScopedTrace objects were being used in place of ATRACE_NAME because of a
misunderstanding of it's function.  Cleared up documentation for usage.

Also explicitly use global namespace for sysprop callback.

Change-Id: I7c248b486b614ccdb841659ca0dcfc644fda670a
parent c3420443

include/utils/Trace.h

+5 −8
Original line number Diff line number Diff line
@@ -31,15 +31,12 @@ 


// See <cutils/trace.h> for more ATRACE_* macros.



// ATRACE_CALL traces the beginning and end of the current function.  To trace

// the correct start and end times this macro should be the first line of the

// function body.

#define ATRACE_CALL() android::ScopedTrace ___tracer(ATRACE_TAG, __FUNCTION__)



// ATRACE_NAME traces the beginning and end of the current function.  To trace

// the correct start and end times this macro should be the first line of the

// function body.

// ATRACE_NAME traces the beginning and end of the current scope.  To trace

// the correct start and end times this macro should be declared first in the

// scope body.

#define ATRACE_NAME(name) android::ScopedTrace ___tracer(ATRACE_TAG, name)

// ATRACE_CALL is an ATRACE_NAME that uses the current function name.

#define ATRACE_CALL() ATRACE_NAME(__FUNCTION__)



namespace android {

libs/utils/Trace.cpp

+1 −1
Original line number Diff line number Diff line
@@ -21,5 +21,5 @@ static void traceInit() __attribute__((constructor)); 


static void traceInit()

{

    android::add_sysprop_change_callback(atrace_update_tags, 0);

    ::android::add_sysprop_change_callback(atrace_update_tags, 0);

}