Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 61366d4b authored by Stephen Crane's avatar Stephen Crane
Browse files

[binder] Move Rust ping_binder() to external API 

The ping_binder() API should be publicly usable on Rust Binder objects.
This change moves this method from the IBinderInternal trait to the
IBinder trait for more general use.

Test: atest rustBinderTest
Bug: 195455757
Change-Id: I1751d9d69ee96197a8f2b577d0150b42445a7d5f
parent ebf9ccac

libs/binder/rust/src/binder.rs

+3 −3
Original line number Diff line number Diff line
@@ -192,9 +192,6 @@ pub trait IBinderInternal: IBinder { 
    /// Is this object still alive?

    fn is_binder_alive(&self) -> bool;



    /// Send a ping transaction to this object

    fn ping_binder(&mut self) -> Result<()>;



    /// Indicate that the service intends to receive caller security contexts.

    #[cfg(not(android_vndk))]

    fn set_requesting_sid(&mut self, enable: bool);
@@ -270,6 +267,9 @@ pub trait IBinder { 
    /// The recipient will no longer be called if this object

    /// dies.

    fn unlink_to_death(&mut self, recipient: &mut DeathRecipient) -> Result<()>;



    /// Send a ping transaction to this object

    fn ping_binder(&mut self) -> Result<()>;

}



/// Opaque reference to the type of a Binder interface.

libs/binder/rust/src/proxy.rs

+11 −11
Original line number Diff line number Diff line
@@ -312,17 +312,6 @@ impl<T: AsNative<sys::AIBinder>> IBinderInternal for T { 
        }

    }



    fn ping_binder(&mut self) -> Result<()> {

        let status = unsafe {

            // Safety: `SpIBinder` guarantees that `self` always contains a

            // valid pointer to an `AIBinder`.

            //

            // This call does not affect ownership of its pointer parameter.

            sys::AIBinder_ping(self.as_native_mut())

        };

        status_result(status)

    }



    #[cfg(not(android_vndk))]

    fn set_requesting_sid(&mut self, enable: bool) {

        unsafe { sys::AIBinder_setRequestingSid(self.as_native_mut(), enable) };
@@ -412,6 +401,17 @@ impl<T: AsNative<sys::AIBinder>> IBinder for T { 
            )

        })

    }



    fn ping_binder(&mut self) -> Result<()> {

        let status = unsafe {

            // Safety: `SpIBinder` guarantees that `self` always contains a

            // valid pointer to an `AIBinder`.

            //

            // This call does not affect ownership of its pointer parameter.

            sys::AIBinder_ping(self.as_native_mut())

        };

        status_result(status)

    }

}



impl Serialize for SpIBinder {