Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5fcf2023 authored by luoqiangwei1's avatar luoqiangwei1
Browse files

Fix dumpstate read_file_as_long fd leak 



Change-Id: If572b05b662695d007854340db0a6d9fb0a7c60d
Signed-off-by: default avatarluoqiangwei1 <luoqiangwei1@xiaomi.com>
parent f3166e46

cmds/dumpstate/dumpstate.cpp

+3 −3
Original line number Diff line number Diff line
@@ -4144,14 +4144,14 @@ int Dumpstate::DumpFile(const std::string& title, const std::string& path) { 
}



int read_file_as_long(const char *path, long int *output) {

    int fd = TEMP_FAILURE_RETRY(open(path, O_RDONLY | O_NONBLOCK | O_CLOEXEC));

    if (fd < 0) {

    android::base::unique_fd fd(TEMP_FAILURE_RETRY(open(path, O_RDONLY | O_NONBLOCK | O_CLOEXEC)));

    if (fd.get() < 0) {

        int err = errno;

        MYLOGE("Error opening file descriptor for %s: %s\n", path, strerror(err));

        return -1;

    }

    char buffer[50];

    ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd, buffer, sizeof(buffer)));

    ssize_t bytes_read = TEMP_FAILURE_RETRY(read(fd.get(), buffer, sizeof(buffer)));

    if (bytes_read == -1) {

        MYLOGE("Error reading file %s: %s\n", path, strerror(errno));

        return -2;