Merge "schedulerservice: implement getMaxAllowedPriority" into oc-dev (5c4122c2) · Commits · e / os / android_frameworks_native

services/schedulerservice/SchedulingPolicyService.cpp

+16 −2

Original line number	Diff line number	Diff line
		@@ -29,23 +29,37 @@ namespace schedulerservice {
		namespace V1_0 {
		namespace implementation {

		Return<bool> SchedulingPolicyService::requestPriority(int32_t pid, int32_t tid, int32_t priority) {
		bool SchedulingPolicyService::isAllowed() {
		using ::android::hardware::IPCThreadState;

		return IPCThreadState::self()->getCallingUid() == AID_CAMERASERVER;
		}

		Return<bool> SchedulingPolicyService::requestPriority(int32_t pid, int32_t tid, int32_t priority) {
		if (priority < static_cast<int32_t>(Priority::MIN) \|\|
		priority > static_cast<int32_t>(Priority::MAX)) {
		return false;
		}

		if (IPCThreadState::self()->getCallingUid() != AID_CAMERASERVER) {
		if (!isAllowed()) {
		return false;
		}

		// TODO(b/37226359): decouple from and remove AIDL service
		// this should always be allowed since we are in system_server.
		int value = ::android::requestPriority(pid, tid, priority, false /* isForApp */);
		return value == 0 /* success */;
		}

		Return<int32_t> SchedulingPolicyService::getMaxAllowedPriority() {
		if (!isAllowed()) {
		return 0;
		}

		// TODO(b/37226359): decouple from and remove AIDL service
		return 3;
		}

		} // namespace implementation
		} // namespace V1_0
		} // namespace schedulerservice

+3 −0

Original line number	Diff line number	Diff line
		@@ -38,6 +38,9 @@ using ::android::sp;

		struct SchedulingPolicyService : public ISchedulingPolicyService {
		Return<bool> requestPriority(int32_t pid, int32_t tid, int32_t priority) override;
		Return<int32_t> getMaxAllowedPriority() override;
		private:
		bool isAllowed();
		};

		} // namespace implementation