Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5af7d855 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: Document future direction of getService. 

I've had a CL a long time which did this here:
https://android-review.googlesource.com/c/platform/frameworks/native/+/1225405/

However, I am not sure how to get confidence in it, and it changes
threading structure, scheduling structure, etc... So I don't think it's
quite the right time to merge it yet.

Bug: n/a
Test: n/a
Change-Id: I83549b920a470387484245587a4714b69765f03f
parent 898879b9

libs/binder/IServiceManager.cpp

+4 −0
Original line number Diff line number Diff line
@@ -205,6 +205,10 @@ ServiceManagerShim::ServiceManagerShim(const sp<AidlServiceManager>& impl) 
 : mTheRealServiceManager(impl)

{}



// This implementation could be simplified and made more efficient by delegating

// to waitForService. However, this changes the threading structure in some

// cases and could potentially break prebuilts. Once we have higher logistical

// complexity, this could be attempted.

sp<IBinder> ServiceManagerShim::getService(const String16& name) const

{

    static bool gSystemBootCompleted = false;