Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 51faf46e authored by Andreas Huber's avatar Andreas Huber
Browse files

Parcel::appendFrom({const } Parcel *parcel, size_t, size_t) 

As far as I can tell "parcel" isn't actually modified by the implementation.

Change-Id: Ib806eefdc13c97b932773e1dc9ca3a4aad4422b2
parent 89675f76

include/binder/Parcel.h

+2 −1
Original line number Diff line number Diff line
@@ -53,7 +53,8 @@ public: 
    

    status_t            setData(const uint8_t* buffer, size_t len);



    status_t            appendFrom(Parcel *parcel, size_t start, size_t len);

    status_t            appendFrom(const Parcel *parcel,

                                   size_t start, size_t len);



    bool                hasFileDescriptors() const;

libs/binder/Parcel.cpp

+3 −3
Original line number Diff line number Diff line
@@ -353,12 +353,12 @@ status_t Parcel::setData(const uint8_t* buffer, size_t len) 
    return err;

}



status_t Parcel::appendFrom(Parcel *parcel, size_t offset, size_t len)

status_t Parcel::appendFrom(const Parcel *parcel, size_t offset, size_t len)

{

    const sp<ProcessState> proc(ProcessState::self());

    status_t err;

    uint8_t *data = parcel->mData;

    size_t *objects = parcel->mObjects;

    const uint8_t *data = parcel->mData;

    const size_t *objects = parcel->mObjects;

    size_t size = parcel->mObjectsSize;

    int startPos = mDataPos;

    int firstIndex = -1, lastIndex = -2;