Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 515f0383 authored by Leon Scroggins III's avatar Leon Scroggins III
Browse files

Add to_string(DisplayCapability) 

For better debugging. This matches other to_string functions, e.g. for
Composition. Use it in the one place I've found a log statement
representing DisplayCapability.

Bug: 193170859
Test: make
Change-Id: Ieb33c5278d2f83f849ca16126230e4dd85c6700e
parent 5967aec4

services/surfaceflinger/DisplayHardware/HWC2.cpp

+2 −2
Original line number Diff line number Diff line
@@ -292,9 +292,9 @@ bool Display::hasCapability(DisplayCapability capability) const { 
        return mDisplayCapabilities->count(capability) > 0;

    }



    ALOGW("Can't query capability %d."

    ALOGW("Can't query capability %s."

          " Display Capabilities were not queried from HWC yet",

          static_cast<int>(capability));

          to_string(capability).c_str());



    return false;

}

services/surfaceflinger/DisplayHardware/Hal.h

+23 −0
Original line number Diff line number Diff line
@@ -118,6 +118,29 @@ inline std::string to_string( 
    }

}



inline std::string to_string(

        aidl::android::hardware::graphics::composer3::DisplayCapability displayCapability) {

    switch (displayCapability) {

        case aidl::android::hardware::graphics::composer3::DisplayCapability::INVALID:

            return "Invalid";

        case aidl::android::hardware::graphics::composer3::DisplayCapability::

                SKIP_CLIENT_COLOR_TRANSFORM:

            return "SkipColorTransform";

        case aidl::android::hardware::graphics::composer3::DisplayCapability::DOZE:

            return "Doze";

        case aidl::android::hardware::graphics::composer3::DisplayCapability::BRIGHTNESS:

            return "Brightness";

        case aidl::android::hardware::graphics::composer3::DisplayCapability::PROTECTED_CONTENTS:

            return "ProtectedContents";

        case aidl::android::hardware::graphics::composer3::DisplayCapability::AUTO_LOW_LATENCY_MODE:

            return "AutoLowLatencyMode";

        case aidl::android::hardware::graphics::composer3::DisplayCapability::SUSPEND:

            return "Suspend";

        default:

            return "Unknown";

    }

}



inline std::string to_string(hardware::graphics::composer::hal::V2_4::Error error) {

    // 5 is reserved for historical reason, during validation 5 means has changes.

    if (ERROR_HAS_CHANGES == static_cast<int32_t>(error)) {