Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c56b645 authored by Ady Abraham's avatar Ady Abraham
Browse files

SF: update mTimestamps with the newest hwvsync timestamp 

When a HWvsync timestamp is dropped since it doesn't match the cadence
of the previous ones, it may still be valid (especially when the older
ones are outdated). In that case update mKnownTimestamp with the new
timestamp.

Bug: 190422841
Test: Tap infrequently in TouchLatency and observe systraces
Change-Id: I10ec8dc1781c891ca280deb2e74bf6e17ce797c5
parent 5ee58153

services/surfaceflinger/Scheduler/VSyncPredictor.cpp

+3 −0
Original line number Diff line number Diff line
@@ -86,6 +86,9 @@ bool VSyncPredictor::addVsyncTimestamp(nsecs_t timestamp) { 
        // in the learning phase we should just clear all timestamps and start

        // over.

        if (mTimestamps.size() < kMinimumSamplesForPrediction) {

            // Add the timestamp to mTimestamps before clearing it so we could

            // update mKnownTimestamp based on the new timestamp.

            mTimestamps.push_back(timestamp);

            clearTimestamps();

        } else if (!mTimestamps.empty()) {

            mKnownTimestamp =

services/surfaceflinger/tests/unittests/VSyncPredictorTest.cpp

+19 −1
Original line number Diff line number Diff line
@@ -478,7 +478,7 @@ TEST_F(VSyncPredictorTest, isVSyncInPhase) { 
    }

}



TEST_F(VSyncPredictorTest, InconsistentVsyncValueIsFlushedEventually) {

TEST_F(VSyncPredictorTest, inconsistentVsyncValueIsFlushedEventually) {

    EXPECT_TRUE(tracker.addVsyncTimestamp(600));

    EXPECT_TRUE(tracker.needsMoreSamples());
@@ -492,6 +492,24 @@ TEST_F(VSyncPredictorTest, InconsistentVsyncValueIsFlushedEventually) { 
    EXPECT_FALSE(tracker.needsMoreSamples());

}



TEST_F(VSyncPredictorTest, knownVsyncIsUpdated) {

    EXPECT_TRUE(tracker.addVsyncTimestamp(600));

    EXPECT_TRUE(tracker.needsMoreSamples());

    EXPECT_EQ(600, tracker.nextAnticipatedVSyncTimeFrom(mNow));



    EXPECT_FALSE(tracker.addVsyncTimestamp(mNow += mPeriod));

    EXPECT_EQ(mNow + 1000, tracker.nextAnticipatedVSyncTimeFrom(mNow));



    for (auto i = 0u; i < kMinimumSamplesForPrediction; i++) {

        EXPECT_TRUE(tracker.needsMoreSamples());

        EXPECT_TRUE(tracker.addVsyncTimestamp(mNow += mPeriod));

        EXPECT_EQ(mNow + 1000, tracker.nextAnticipatedVSyncTimeFrom(mNow));

    }



    EXPECT_FALSE(tracker.needsMoreSamples());

    EXPECT_EQ(mNow + 1000, tracker.nextAnticipatedVSyncTimeFrom(mNow));

}



} // namespace android::scheduler



// TODO(b/129481165): remove the #pragma below and fix conversion issues