Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a63393e authored by Lloyd Pique's avatar Lloyd Pique
Browse files

SF unit test: Disable flaky tests 

A good number of OneShotTimer tests were flaky. This changes marks them
as DISABLED, with a comment linking to the bug.

Bug: 186417847
Test: libsurfaceflinger_unittest # Tests marked disabled
Change-Id: I75a034e6a79e0469b3a321e410ca0d6db36bd5fe
parent 87af6fa0

services/surfaceflinger/tests/unittests/OneShotTimerTest.cpp

+8 −4
Original line number Diff line number Diff line
@@ -72,7 +72,8 @@ TEST_F(OneShotTimerTest, startStopTest) { 
    mIdleTimer->stop();

}



TEST_F(OneShotTimerTest, resetTest) {

// TODO(b/186417847) This test is flaky. Reenable once fixed.

TEST_F(OneShotTimerTest, DISABLED_resetTest) {

    fake::FakeClock* clock = new fake::FakeClock();

    mIdleTimer = std::make_unique<scheduler::OneShotTimer>("TestTimer", 1ms,

                                                           mResetTimerCallback.getInvocable(),
@@ -94,7 +95,8 @@ TEST_F(OneShotTimerTest, resetTest) { 
    EXPECT_FALSE(mResetTimerCallback.waitForUnexpectedCall().has_value());

}



TEST_F(OneShotTimerTest, resetBackToBackTest) {

// TODO(b/186417847) This test is flaky. Reenable once fixed.

TEST_F(OneShotTimerTest, DISABLED_resetBackToBackTest) {

    fake::FakeClock* clock = new fake::FakeClock();

    mIdleTimer = std::make_unique<scheduler::OneShotTimer>("TestTimer", 1ms,

                                                           mResetTimerCallback.getInvocable(),
@@ -144,7 +146,8 @@ TEST_F(OneShotTimerTest, startNotCalledTest) { 
    EXPECT_FALSE(mResetTimerCallback.waitForUnexpectedCall().has_value());

}



TEST_F(OneShotTimerTest, idleTimerIdlesTest) {

// TODO(b/186417847) This test is flaky. Reenable once fixed.

TEST_F(OneShotTimerTest, DISABLED_idleTimerIdlesTest) {

    fake::FakeClock* clock = new fake::FakeClock();

    mIdleTimer = std::make_unique<scheduler::OneShotTimer>("TestTimer", 1ms,

                                                           mResetTimerCallback.getInvocable(),
@@ -169,7 +172,8 @@ TEST_F(OneShotTimerTest, idleTimerIdlesTest) { 
    EXPECT_FALSE(mResetTimerCallback.waitForUnexpectedCall().has_value());

}



TEST_F(OneShotTimerTest, timeoutCallbackExecutionTest) {

// TODO(b/186417847) This test is flaky. Reenable once fixed.

TEST_F(OneShotTimerTest, DISABLED_timeoutCallbackExecutionTest) {

    fake::FakeClock* clock = new fake::FakeClock();

    mIdleTimer = std::make_unique<scheduler::OneShotTimer>("TestTimer", 1ms,

                                                           mResetTimerCallback.getInvocable(),