Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a5441fe authored by Yu-Ting Tseng's avatar Yu-Ting Tseng
Browse files

Placeholder for binder freeze notification API. 

Adding the placeholder APIs to validate whether this breaks existing
prebuilts.

Bug: 338097747
Change-Id: Id7357076ad98c1f220a78186fe509326047cf922
Test: m
parent ac728795

libs/binder/Binder.cpp

+8 −0
Original line number Original line Diff line number Diff line
@@ -441,6 +441,14 @@ status_t BBinder::unlinkToDeath( 
    return INVALID_OPERATION;

    return INVALID_OPERATION;

}

}





status_t BBinder::addFrozenStateChangeCallback(const wp<FrozenStateChangeCallback>&) {

    return INVALID_OPERATION;

}



status_t BBinder::removeFrozenStateChangeCallback(const wp<FrozenStateChangeCallback>&) {

    return INVALID_OPERATION;

}



status_t BBinder::dump(int /*fd*/, const Vector<String16>& /*args*/)

status_t BBinder::dump(int /*fd*/, const Vector<String16>& /*args*/)

{

{

    return NO_ERROR;

    return NO_ERROR;

libs/binder/BpBinder.cpp

+8 −0
Original line number Original line Diff line number Diff line
@@ -557,6 +557,14 @@ void BpBinder::sendObituary() 
    }

    }

}

}





status_t BpBinder::addFrozenStateChangeCallback(const wp<FrozenStateChangeCallback>&) {

    return INVALID_OPERATION;

}



status_t BpBinder::removeFrozenStateChangeCallback(const wp<FrozenStateChangeCallback>&) {

    return INVALID_OPERATION;

}



void BpBinder::reportOneDeath(const Obituary& obit)

void BpBinder::reportOneDeath(const Obituary& obit)

{

{

    sp<DeathRecipient> recipient = obit.recipient.promote();

    sp<DeathRecipient> recipient = obit.recipient.promote();

libs/binder/include/binder/Binder.h

+7 −0
Original line number Original line Diff line number Diff line
@@ -50,6 +50,13 @@ public: 
                                                      void* cookie = nullptr, uint32_t flags = 0,

                                                      void* cookie = nullptr, uint32_t flags = 0,

                                                      wp<DeathRecipient>* outRecipient = nullptr);

                                                      wp<DeathRecipient>* outRecipient = nullptr);





    // Placeholders to test if adding virtual functions here breaks things.

    // Will be replaced by an actual API once things are verified to work.

    LIBBINDER_EXPORTED virtual status_t addFrozenStateChangeCallback(

            const wp<FrozenStateChangeCallback>& callback);

    LIBBINDER_EXPORTED virtual status_t removeFrozenStateChangeCallback(

            const wp<FrozenStateChangeCallback>& callback);



    LIBBINDER_EXPORTED virtual void* attachObject(const void* objectID, void* object,

    LIBBINDER_EXPORTED virtual void* attachObject(const void* objectID, void* object,

                                                  void* cleanupCookie,

                                                  void* cleanupCookie,

                                                  object_cleanup_func func) final;

                                                  object_cleanup_func func) final;

libs/binder/include/binder/BpBinder.h

+6 −0
Original line number Original line Diff line number Diff line
@@ -66,6 +66,12 @@ public: 
                                                      void* cookie = nullptr, uint32_t flags = 0,

                                                      void* cookie = nullptr, uint32_t flags = 0,

                                                      wp<DeathRecipient>* outRecipient = nullptr);

                                                      wp<DeathRecipient>* outRecipient = nullptr);





    [[nodiscard]] virtual status_t addFrozenStateChangeCallback(

            const wp<FrozenStateChangeCallback>& recipient);



    [[nodiscard]] virtual status_t removeFrozenStateChangeCallback(

            const wp<FrozenStateChangeCallback>& recipient);



    LIBBINDER_EXPORTED virtual void* attachObject(const void* objectID, void* object,

    LIBBINDER_EXPORTED virtual void* attachObject(const void* objectID, void* object,

                                                  void* cleanupCookie,

                                                  void* cleanupCookie,

                                                  object_cleanup_func func) final;

                                                  object_cleanup_func func) final;

libs/binder/include/binder/IBinder.h

+14 −3
Original line number Original line Diff line number Diff line
@@ -198,6 +198,11 @@ public: 
        virtual void binderDied(const wp<IBinder>& who) = 0;

        virtual void binderDied(const wp<IBinder>& who) = 0;

    };

    };





    class FrozenStateChangeCallback : public virtual RefBase {

    public:

        virtual void onStateChanged(const wp<IBinder>& who, bool isFrozen) = 0;

    };



#if defined(__clang__)

#if defined(__clang__)

#pragma clang diagnostic pop

#pragma clang diagnostic pop

#endif

#endif
@@ -249,6 +254,12 @@ public: 
                                            uint32_t flags = 0,

                                            uint32_t flags = 0,

                                            wp<DeathRecipient>* outRecipient = nullptr) = 0;

                                            wp<DeathRecipient>* outRecipient = nullptr) = 0;





    // Placeholders. See Binder.h for details.

    [[nodiscard]] virtual status_t addFrozenStateChangeCallback(

            const wp<FrozenStateChangeCallback>& callback) = 0;

    [[nodiscard]] virtual status_t removeFrozenStateChangeCallback(

            const wp<FrozenStateChangeCallback>& callback) = 0;



    virtual bool            checkSubclass(const void* subclassID) const;

    virtual bool            checkSubclass(const void* subclassID) const;





    typedef void (*object_cleanup_func)(const void* id, void* obj, void* cleanupCookie);

    typedef void (*object_cleanup_func)(const void* id, void* obj, void* cleanupCookie);