Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44235112 authored by Christopher Tate's avatar Christopher Tate
Browse files

Correct overflow check in Parcel resize code 

Bug 31929765

Change-Id: Ie27b9945f1de056624668869bdf9a5578abff467
parent 04ac2933

libs/binder/Parcel.cpp

+2 −2
Original line number Original line Diff line number Diff line
@@ -514,7 +514,7 @@ status_t Parcel::appendFrom(const Parcel *parcel, size_t offset, size_t len) 
        // grow objects

        // grow objects

        if (mObjectsCapacity < mObjectsSize + numObjects) {

        if (mObjectsCapacity < mObjectsSize + numObjects) {

            size_t newSize = ((mObjectsSize + numObjects)*3)/2;

            size_t newSize = ((mObjectsSize + numObjects)*3)/2;

            if (newSize < mObjectsSize) return NO_MEMORY;   // overflow

            if (newSize*sizeof(binder_size_t) < mObjectsSize) return NO_MEMORY;   // overflow

            binder_size_t *objects =

            binder_size_t *objects =

                (binder_size_t*)realloc(mObjects, newSize*sizeof(binder_size_t));

                (binder_size_t*)realloc(mObjects, newSize*sizeof(binder_size_t));

            if (objects == (binder_size_t*)0) {

            if (objects == (binder_size_t*)0) {
@@ -1314,7 +1314,7 @@ restart_write: 
    }

    }

    if (!enoughObjects) {

    if (!enoughObjects) {

        size_t newSize = ((mObjectsSize+2)*3)/2;

        size_t newSize = ((mObjectsSize+2)*3)/2;

        if (newSize < mObjectsSize) return NO_MEMORY;   // overflow

        if (newSize*sizeof(binder_size_t) < mObjectsSize) return NO_MEMORY;   // overflow

        binder_size_t* objects = (binder_size_t*)realloc(mObjects, newSize*sizeof(binder_size_t));

        binder_size_t* objects = (binder_size_t*)realloc(mObjects, newSize*sizeof(binder_size_t));

        if (objects == NULL) return NO_MEMORY;

        if (objects == NULL) return NO_MEMORY;

        mObjects = objects;

        mObjects = objects;