Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3f242853 authored by Martin Stjernholm's avatar Martin Stjernholm Committed by Gerrit Code Review
Browse files

Merge changes Ie98c9fec,I2de6bc77 

* changes:
  Fix bug when there are no packages to OTA dexopt.
  Improve error reporting in OTA dexopt code.
parents b43fced6 5c6bf399

cmds/installd/otapreopt.cpp

+2 −2
Original line number Diff line number Diff line
@@ -308,7 +308,7 @@ private: 
        // This is different from the normal installd. We only do the base

        // directory, the rest will be created on demand when each app is compiled.

        if (access(GetOtaDirectoryPrefix().c_str(), R_OK) < 0) {

            LOG(ERROR) << "Could not access " << GetOtaDirectoryPrefix();

            PLOG(ERROR) << "Could not access " << GetOtaDirectoryPrefix();

            return false;

        }
@@ -460,7 +460,7 @@ private: 
        // this tool will wipe the OTA artifact cache and try again (for robustness after

        // a failed OTA with remaining cache artifacts).

        if (access(apk_path, F_OK) != 0) {

            LOG(WARNING) << "Skipping A/B OTA preopt of non-existing package " << apk_path;

            PLOG(WARNING) << "Skipping A/B OTA preopt of non-existing package " << apk_path;

            return true;

        }

cmds/installd/otapreopt_script.sh

+7 −7
Original line number Diff line number Diff line
@@ -60,6 +60,11 @@ print -u${STATUS_FD} "global_progress $PROGRESS" 


i=0

while ((i<MAXIMUM_PACKAGES)) ; do

  DONE=$(cmd otadexopt done)

  if [ "$DONE" = "OTA complete." ] ; then

    break

  fi



  DEXOPT_PARAMS=$(cmd otadexopt next)



  /system/bin/otapreopt_chroot $STATUS_FD $TARGET_SLOT_SUFFIX $DEXOPT_PARAMS >&- 2>&-
@@ -67,13 +72,8 @@ while ((i<MAXIMUM_PACKAGES)) ; do 
  PROGRESS=$(cmd otadexopt progress)

  print -u${STATUS_FD} "global_progress $PROGRESS"



  DONE=$(cmd otadexopt done)

  if [ "$DONE" = "OTA incomplete." ] ; then

  sleep 1

  i=$((i+1))

    continue

  fi

  break

done



DONE=$(cmd otadexopt done)