Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ef3c4d9 authored by Prabir Pradhan's avatar Prabir Pradhan
Browse files

ExternalStylusIntegrationTest: Reduce likelihood for flake 

In the test, an event will be generated after a 72ms timeout, and
we assert that no event is generated before that timeout. Since this
is a racy assertion, just wait for 1ms to ensure that an event isn't
immediately generated.

If this is not enough to bring the flakes rates to an acceptable level,
we will need to refactor the tests to remove the race altogether.

Bug: 386801813
Change-Id: Id223930925ce724e216e61a9e68e1da79bed6f04
Test: Presubmit
Flag: TEST_ONLY
parent edc71465

services/inputflinger/tests/InputReader_test.cpp

+4 −4
Original line number Diff line number Diff line
@@ -2474,10 +2474,10 @@ TEST_F(ExternalStylusIntegrationTest, FusedExternalStylusPressureNotReported) { 
    const auto syncTime = std::chrono::system_clock::now();

    // After 72 ms, the event *will* be generated. If we wait the full 72 ms to check that NO event

    // is generated in that period, there will be a race condition between the event being generated

    // and the test's wait timeout expiring. Thus, we wait for a shorter duration in the test, which

    // will reduce the liklihood of the race condition occurring.

    const auto waitUntilTimeForNoEvent =

            syncTime + std::chrono::milliseconds(ns2ms(EXTERNAL_STYLUS_DATA_TIMEOUT / 2));

    // and the test's wait timeout expiring. Thus, we wait for a shorter duration in the test to

    // ensure the event is not immediately generated, which should reduce the liklihood of the race

    // condition occurring.

    const auto waitUntilTimeForNoEvent = syncTime + std::chrono::milliseconds(1);

    mDevice->sendSync();

    ASSERT_NO_FATAL_FAILURE(mTestListener->assertNotifyMotionWasNotCalled(waitUntilTimeForNoEvent));