Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3e7dad57 authored by Daniel Nicoara's avatar Daniel Nicoara
Browse files

VR HWC: Relax checks around layer presentation 

Rather than error out on layers without buffers, simply discard them.
This is more in line with other HWComposer implementations which deal
with this error, since SurfaceFlinger doesn't handle it appropriately.

Bug: 37091090
Test: Ran on device and verified errors are no longer reported in logcat
Change-Id: Iacfd9fa707d86367c7b6dbf62edea297fc9dfb8e
parent de73eb10

services/vr/vr_window_manager/composer/impl/vr_hwc.cpp

+2 −7
Original line number Diff line number Diff line
@@ -217,19 +217,14 @@ Error HwcDisplay::GetFrame( 
      queued_client_target = true;

    } else {

      if (!layer.info.buffer.get() || !layer.info.fence.get()) {

        ALOGE("Layer requested without valid buffer");

        return Error::BAD_LAYER;

        ALOGV("Layer requested without valid buffer");

        continue;

      }



      frame.push_back(layer.info);

    }

  }



  if (frame.empty()) {

    ALOGE("Requested frame with no layers");

    return Error::BAD_LAYER;

  }



  out_frames->swap(frame);

  return Error::NONE;

}