Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37adb719 authored by Steven Moreland's avatar Steven Moreland
Browse files

RPC Binder: always log ENOMEM in guest 

We are seeeing ENOMEM reported from the guest, but
we don't see the logs that we think we should be
seeing from the guest at that time. Always log this
case, so when the issue reproduces, we will know
whether there is a missing log issue, or if the
error is coming from some other unexpected place
which does not otherwise log.

Bug: 416772676
Test: N/A
Change-Id: I34ac052befe6ea70ea26ac11c46a52ab39d7db7c
parent 13234703

libs/binder/RpcState.cpp

+8 −0
Original line number Diff line number Diff line
@@ -1184,6 +1184,14 @@ processTransactInternalTailCall: 
        replyStatus = status;

    }



    // b/404210068 - we see this case with no logs in the VM. Make sure we always log in this

    // case, so if the bug repros again, we prove that there are missing logs. Try the negative

    // as well to be extra careful. TODO - delete this code anytime in the future.

    if (replyStatus == NO_MEMORY || replyStatus == ENOMEM) {

        ALOGE("Replying to transaction code: %" PRIo32 " error: %s.", transaction->code,

              statusToString(replyStatus).c_str());

    }



    auto* rpcFields = reply.maybeRpcFields();

    LOG_ALWAYS_FATAL_IF(rpcFields == nullptr);