Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3175c094 authored by Colin Cross's avatar Colin Cross
Browse files

Fix rule of three warnings 

Sensor and BufferItem have destructors, the copy constructor and
assignment operators should not be implicit. The warnings were being
hidden by the use of -isystem to include frameworks/native/include.

Bug: 31752268
Test: m -j
Change-Id: If375d85cd3d6ded4ee6b27b841bf10f563254682
parent 9984fa0e

include/gui/BufferItem.h

+2 −0
Original line number Diff line number Diff line
@@ -46,6 +46,8 @@ class BufferItem : public Flattenable<BufferItem> { 
    enum { INVALID_BUFFER_SLOT = -1 };

    BufferItem();

    ~BufferItem();

    BufferItem(const BufferItem&) = default;

    BufferItem& operator=(const BufferItem&) = default;



    static const char* scalingModeName(uint32_t scalingMode);

include/gui/Sensor.h

+3 −0
Original line number Diff line number Diff line
@@ -61,6 +61,9 @@ public: 
        uuid_t() : b{0} {}

    };



    Sensor(const Sensor&) = default;

    Sensor& operator=(const Sensor&) = default;



    Sensor(const char * name = "");

    Sensor(struct sensor_t const* hwSensor, int halVersion = 0);

    Sensor(struct sensor_t const& hwSensor, const uuid_t& uuid, int halVersion = 0);