Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 29936fa1 authored by Darwin Huang's avatar Darwin Huang
Browse files

BufferQueueProducer: Log verbose log to warning instead of error. 

Previously, this printed very verbose/spammy logs when there was
nothing actionable  users or developers could do to improve what
seemed like correct behavior to the user. Move this log to 'warning'
to still provide the information while reducing spam.


Bug: http://b/140581935
Change-Id: Iba5fc100a99594a7ac6df240b2468ffedfde249c
parent c52533cd

libs/gui/BufferQueueProducer.cpp

+4 −1
Original line number Diff line number Diff line
@@ -645,7 +645,10 @@ status_t BufferQueueProducer::detachBuffer(int slot) { 
                    slot, BufferQueueDefs::NUM_BUFFER_SLOTS);

            return BAD_VALUE;

        } else if (!mSlots[slot].mBufferState.isDequeued()) {

            BQ_LOGE("detachBuffer: slot %d is not owned by the producer "

            // TODO(http://b/140581935): This message is BQ_LOGW because it

            // often logs when no actionable errors are present. Return to

            // using BQ_LOGE after ensuring this only logs during errors.

            BQ_LOGW("detachBuffer: slot %d is not owned by the producer "

                    "(state = %s)", slot, mSlots[slot].mBufferState.string());

            return BAD_VALUE;

        } else if (!mSlots[slot].mRequestBufferCalled) {