Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28178135 authored by Yiwei Zhang's avatar Yiwei Zhang
Browse files

systrace: avoid queuing signaled fence in FenceMonitor 

If the HWC release fence dequeued has already signaled, the existing
mechanism will still queue it and show it later if there's release fence
waiting, which is not accurate. This change will avoid queuing signaled
fences into FenceMonitor to make the trace more reasonable.

Bug: 127781085
Test: build, flash, boot and take systrace with gfx category
Change-Id: Ie607f690bba8ccdfab4d02793abcf21e18c3eb63
parent 9e919eb8

libs/gui/Surface.cpp

+9 −1
Original line number Diff line number Diff line
@@ -467,7 +467,15 @@ public: 
        char message[64];



        std::lock_guard<std::mutex> lock(mMutex);

        snprintf(message, sizeof(message), "Trace fence %u", mFencesQueued);

        if (fence->getSignalTime() != Fence::SIGNAL_TIME_PENDING) {

            snprintf(message, sizeof(message), "%s fence %u has signaled", mName, mFencesQueued);

            ATRACE_NAME(message);

            // Need an increment on both to make the trace number correct.

            mFencesQueued++;

            mFencesSignaled++;

            return;

        }

        snprintf(message, sizeof(message), "Trace %s fence %u", mName, mFencesQueued);

        ATRACE_NAME(message);



        mQueue.push_back(fence);