Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 27224160 authored by Colin Cross's avatar Colin Cross
Browse files

Fix order of operations warning in libui 

The warnings were being hidden by the use of -isystem to include
frameworks/native/include.

Bug: 31752268
Test: m -j
Change-Id: I21f34567927125d3eeeecd8f00271a175f93af21
parent a2362b44

include/ui/Gralloc1On0Adapter.h

+2 −2
Original line number Diff line number Diff line
@@ -416,10 +416,10 @@ private: 
        if (!outData) {

            const auto producerCpuUsage = GRALLOC1_PRODUCER_USAGE_CPU_READ |

                    GRALLOC1_PRODUCER_USAGE_CPU_WRITE;

            if (producerUsage & producerCpuUsage != 0) {

            if ((producerUsage & producerCpuUsage) != 0) {

                return static_cast<int32_t>(GRALLOC1_ERROR_BAD_VALUE);

            }

            if (consumerUsage & GRALLOC1_CONSUMER_USAGE_CPU_READ != 0) {

            if ((consumerUsage & GRALLOC1_CONSUMER_USAGE_CPU_READ) != 0) {

                return static_cast<int32_t>(GRALLOC1_ERROR_BAD_VALUE);

            }

        }