Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Skip to content
Commit 1f3d886c authored by Abhijeet Kaur's avatar Abhijeet Kaur
Browse files

Remove screenshot_fd as optional param

Binder does not allow invalid fd to be passed in function calls, so
remove "optional" in IDumpstate.aidl

Also, remove TODO to make screenshot fd optional, as the binder call
requires valid screenshot fd.

Also, we do not need valid screenshot fd for lite bugreports
(wifi/telephony/interactive etc). Although the Binder makes sure that
valid fds are passed, this is just an additional check on top of that.

Bug: 128981582
Test: * adb shell mkdir /data/nativetest64
      * mmm -j frameworks/native/cmds/dumpstate/ &&
        adb push ${OUT}/data/nativetest64/dumpstate_test* /data/nativetest64 &&
	adb shell /data/nativetest64/dumpstate_test/dumpstate_test &&
	printf "\n\n#### ALL TESTS PASSED ####\n"
Change-Id: Idf6093832fea0f11f12ff2bc0fd1dcec6fd502df
parent 0a75a6ae
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment