Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ef0eb66 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: BBinder descriptor 

Two reasons:
- expose information to client (helps debugging)
- client code re-fetches blank descriptor

libbinder_ndk always requires a descriptor and
JavaBBinder overrides this method, so there is no
app compat concern.

Bug: N/A (though noticed in development of b/238777741)
Test: binderLibTest
Change-Id: Id31ac631b929350b97ab865c720f1dc1dfa26d2b
parent a417e313

libs/binder/Binder.cpp

+3 −5
Original line number Diff line number Diff line
@@ -272,11 +272,9 @@ status_t BBinder::pingBinder() 


const String16& BBinder::getInterfaceDescriptor() const

{

    // This is a local static rather than a global static,

    // to avoid static initializer ordering issues.

    static String16 sEmptyDescriptor;

    ALOGW("reached BBinder::getInterfaceDescriptor (this=%p)", this);

    return sEmptyDescriptor;

    static StaticString16 sBBinder(u"BBinder");

    ALOGW("Reached BBinder::getInterfaceDescriptor (this=%p). Override?", this);

    return sBBinder;

}



// NOLINTNEXTLINE(google-default-arguments)