Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c6f4551 authored by Devin Moore's avatar Devin Moore
Browse files

Allow access check to fail to deny when selinux is not being enforced 

Flag: TEST_ONLY
Test: atest libbinder_ndk_unit_test
Bug: 412182995
Change-Id: I9f24abede251acffa2b0928386f37058148a4211
parent dbfb1d9b

libs/binder/ndk/tests/Android.bp

+4 −3
Original line number Diff line number Diff line
@@ -33,12 +33,12 @@ cc_defaults { 
    },

    cflags: [

        "-O0",

        "-g",

        "-Wall",

        "-Werror",

        "-Wextra",

        "-Wextra-semi",

        "-Werror",

        "-Winconsistent-missing-override",

        "-g",

    ],

}
@@ -60,6 +60,7 @@ cc_defaults { 
        "libbase",

        "libbinder",

        "libbinder_ndk",

        "libselinux",

        "libutils",

    ],

    static_libs: [
@@ -97,8 +98,8 @@ cc_test_host { 
    },

    static_libs: [

        "libbase",

        "libbinder_ndk",

        "libbinder",

        "libbinder_ndk",

        "libcutils",

        "libfakeservicemanager",

        "libgmock",

libs/binder/ndk/tests/libbinder_ndk_unit_test.cpp

+5 −3
Original line number Diff line number Diff line
@@ -25,6 +25,7 @@ 
#include <android/binder_process.h>

#include <gtest/gtest.h>

#include <iface/iface.h>

#include <selinux/selinux.h>

#include <utils/Looper.h>



// warning: this is assuming that libbinder_ndk is using the same copy
@@ -1098,7 +1099,8 @@ TEST(NdkBinder, CheckServiceAccessOk) { 
}



TEST(NdkBinder, CheckServiceAccessNotOk) {

    EXPECT_FALSE(AServiceManager_checkServiceAccess(

    bool is_enforcing = security_getenforce() == 1;

    EXPECT_NE(is_enforcing, AServiceManager_checkServiceAccess(

                                    "u:r:some_unknown_sid:s0", 0, 0, "adb",

                                    AServiceManager_PermissionType::CHECK_ACCESS_PERMISSION_FIND));

}