Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b386586 authored by karthik bharadwaj's avatar karthik bharadwaj
Browse files

Validate Shell Command Input Argument Vector

A fuzz test revealed that the input argument list vector
was not being validated for size, leading to a out-of-bounds
read for an empty vector.

Bug: 154500963
Test: Trivial fix
Change-Id: I8186d33eb72c036263fd0bd1b693a5d44ffb3a9f
parent 9d52426f
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -699,6 +699,9 @@ status_t SensorService::shellCommand(int in, int out, int err, Vector<String16>&
    if (!checkCallingPermission(sManageSensorsPermission, nullptr, nullptr)) {
        return PERMISSION_DENIED;
    }
    if (args.size() == 0) {
      return BAD_INDEX;
    }
    if (in == BAD_TYPE || out == BAD_TYPE || err == BAD_TYPE) {
        return BAD_VALUE;
    }