Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1892789e authored by Alice Ryhl's avatar Alice Ryhl
Browse files

IPCThreadState: remove spurious call to readInt32 in BC_FROZEN_BINDER 

The actual value of isFrozen is provided as part of the
binder_frozen_state_info that we already read in the readInPlace() call.
The only reason that reading a spurious i32 doesn't break anything is
that the buffer is always empty in this scenario because the kernel
driver stops after delivering BC_FROZEN_BINDER under the assumption that
they might result in transactions.

Test: binderLibTest
Flag: EXEMPT bugfix
Change-Id: Iae2add531ddfffedb91ad9dd42efd338c9b434f8
parent 10794d7f

libs/binder/IPCThreadState.cpp

+0 −1
Original line number Diff line number Diff line
@@ -1617,7 +1617,6 @@ status_t IPCThreadState::executeCommand(int32_t cmd) 
                break;

            }

            BpBinder* proxy = (BpBinder*)data->cookie;

            bool isFrozen = mIn.readInt32() > 0;

            proxy->getPrivateAccessor().onFrozenStateChanged(data->is_frozen);

            mOut.writeInt32(BC_FREEZE_NOTIFICATION_DONE);

            mOut.writePointer(data->cookie);