Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 158b63da authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: Inet SocketAddr contains raw port 

In preparation for being able to call 'getaddrinfo' from inside this
object, which is required to setup dynamic threads. As a side-effect,
this also saves a heap allocation in the happy path.

Bug: 185167543
Test: N/A
Change-Id: I689d083876acf58d8d868d81d66508b91914b8a9
parent 379dbd1c

libs/binder/RpcConnection.cpp

+14 −17
Original line number Diff line number Diff line
@@ -132,22 +132,19 @@ bool RpcConnection::addVsockClient(unsigned int cid, unsigned int port) { 


class SocketAddressImpl : public RpcConnection::SocketAddress {

public:

    SocketAddressImpl(const sockaddr* addr, size_t size, const String8& desc)

          : mAddr(addr), mSize(size), mDesc(desc) {}

    SocketAddressImpl(const sockaddr* sockAddr, size_t size, const char* addr, unsigned int port)

          : mSockAddr(sockAddr), mSize(size), mAddr(addr), mPort(port) {}

    [[nodiscard]] std::string toString() const override {

        return std::string(mDesc.c_str(), mDesc.size());

        return String8::format("%s:%u", mAddr, mPort).c_str();

    }

    [[nodiscard]] const sockaddr* addr() const override { return mAddr; }

    [[nodiscard]] const sockaddr* addr() const override { return mSockAddr; }

    [[nodiscard]] size_t addrSize() const override { return mSize; }

    void set(const sockaddr* addr, size_t size) {

        mAddr = addr;

        mSize = size;

    }



private:

    const sockaddr* mAddr = nullptr;

    size_t mSize = 0;

    String8 mDesc;

    const sockaddr* mSockAddr;

    size_t mSize;

    const char* mAddr;

    unsigned int mPort;

};



AddrInfo GetAddrInfo(const char* addr, unsigned int port) {
@@ -170,14 +167,15 @@ AddrInfo GetAddrInfo(const char* addr, unsigned int port) { 
}



bool RpcConnection::setupInetServer(unsigned int port) {

    auto aiStart = GetAddrInfo("127.0.0.1", port);

    const char* kAddr = "127.0.0.1";



    auto aiStart = GetAddrInfo(kAddr, port);

    if (aiStart == nullptr) return false;

    SocketAddressImpl socketAddress(nullptr, 0, String8::format("127.0.0.1:%u", port));

    for (auto ai = aiStart.get(); ai != nullptr; ai = ai->ai_next) {

        socketAddress.set(ai->ai_addr, ai->ai_addrlen);

        SocketAddressImpl socketAddress(ai->ai_addr, ai->ai_addrlen, kAddr, port);

        if (setupSocketServer(socketAddress)) return true;

    }

    ALOGE("None of the socket address resolved for 127.0.0.1:%u can be set up as inet server.",

    ALOGE("None of the socket address resolved for %s:%u can be set up as inet server.", kAddr,

          port);

    return false;

}
@@ -185,9 +183,8 @@ bool RpcConnection::setupInetServer(unsigned int port) { 
bool RpcConnection::addInetClient(const char* addr, unsigned int port) {

    auto aiStart = GetAddrInfo(addr, port);

    if (aiStart == nullptr) return false;

    SocketAddressImpl socketAddress(nullptr, 0, String8::format("%s:%u", addr, port));

    for (auto ai = aiStart.get(); ai != nullptr; ai = ai->ai_next) {

        socketAddress.set(ai->ai_addr, ai->ai_addrlen);

        SocketAddressImpl socketAddress(ai->ai_addr, ai->ai_addrlen, addr, port);

        if (addSocketClient(socketAddress)) return true;

    }

    ALOGE("None of the socket address resolved for %s:%u can be added as inet client.", addr, port);