Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 117556e0 authored by Melody Hsu's avatar Melody Hsu
Browse files

Remove unecessary flag checks for Transaction#setFlags 

The if statement does not provide any value and is an
additional area to have to maintain when introducing
new flags.

Bug: 371381313
Test: presubmit
Flag: EXEMPT bug fix
Change-Id: Ie1a929451aaa6d87e82e9ab131ddb50d2d70cee3
parent 886c2c04

libs/gui/SurfaceComposerClient.cpp

+1 −8
Original line number Diff line number Diff line
@@ -1539,14 +1539,7 @@ SurfaceComposerClient::Transaction& SurfaceComposerClient::Transaction::setFlags 
        mStatus = BAD_INDEX;

        return *this;

    }

    if ((mask & layer_state_t::eLayerOpaque) || (mask & layer_state_t::eLayerHidden) ||

        (mask & layer_state_t::eLayerSecure) || (mask & layer_state_t::eLayerSkipScreenshot) ||

        (mask & layer_state_t::eEnableBackpressure) ||

        (mask & layer_state_t::eIgnoreDestinationFrame) ||

        (mask & layer_state_t::eLayerIsDisplayDecoration) ||

        (mask & layer_state_t::eLayerIsRefreshRateIndicator)) {

    s->what |= layer_state_t::eFlagsChanged;

    }

    s->flags &= ~mask;

    s->flags |= (flags & mask);

    s->mask |= mask;