Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0eb86bfb authored by Nandana Dutt's avatar Nandana Dutt
Browse files

Rename IDumpstateListener errorcode 

BUG:123571915
Test: adb shell /data/nativetest64/dumpstate_smoke_test/dumpstate_smoke_test --gtest_filter=DumpstateBinderTest.*
Change-Id: I5533f3bfed647a4068893b61dee371f5a4678650
parent 01f59ce0

cmds/dumpstate/DumpstateService.cpp

+1 −1
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ binder::Status DumpstateService::startBugreport(int32_t calling_uid, 
    if (ds_ != nullptr) {

        MYLOGE("Error! There is already a bugreport in progress. Returning.");

        if (listener != nullptr) {

            listener->onError(IDumpstateListener::BUGREPORT_ERROR_CONCURRENT_BUGREPORTS_FORBIDDEN);

            listener->onError(IDumpstateListener::BUGREPORT_ERROR_ANOTHER_REPORT_IN_PROGRESS);

        }

        return exception(binder::Status::EX_SERVICE_SPECIFIC,

                         "There is already a bugreport in progress");

cmds/dumpstate/binder/android/os/IDumpstateListener.aidl

+1 −1
Original line number Diff line number Diff line
@@ -50,7 +50,7 @@ interface IDumpstateListener { 
    const int BUGREPORT_ERROR_USER_CONSENT_TIMED_OUT = 4;



    /* There is currently a bugreport running. The caller should try again later. */

    const int BUGREPORT_ERROR_CONCURRENT_BUGREPORTS_FORBIDDEN = 5;

    const int BUGREPORT_ERROR_ANOTHER_REPORT_IN_PROGRESS = 5;



    /**

     * Called on an error condition with one of the error codes listed above.

cmds/dumpstate/tests/dumpstate_smoke_test.cpp

+1 −1
Original line number Diff line number Diff line
@@ -475,7 +475,7 @@ TEST_F(DumpstateBinderTest, SimultaneousBugreportsNotAllowed) { 
    EXPECT_FALSE(status.isOk());

    WaitTillExecutionComplete(listener2.get());

    EXPECT_EQ(listener2->getErrorCode(),

              IDumpstateListener::BUGREPORT_ERROR_CONCURRENT_BUGREPORTS_FORBIDDEN);

              IDumpstateListener::BUGREPORT_ERROR_ANOTHER_REPORT_IN_PROGRESS);



    // Meanwhile the first call works as expected. Service should not die in this case.

    WaitTillExecutionComplete(listener1.get());