Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b9c9a81 authored by Steven Moreland's avatar Steven Moreland
Browse files

libbinder: avoid BpBinder subclasses 

Being able to modify sizeof(BpBinder) at our discretion is very
important in order to prevent additional heap allocations. No one tends
to subclass this, because they are always created by Parcel, but at the
same time, we don't need to expose this possibility.

Bug: 167966510
Test: build only
Change-Id: I30c813d3de91043c46d235448fce41bac8fe5621
parent 2df4e052

libs/binder/include/binder/BpBinder.h

+1 −3
Original line number Original line Diff line number Diff line
@@ -109,15 +109,13 @@ public: 
        KeyedVector<const void*, entry_t> mObjects;

        KeyedVector<const void*, entry_t> mObjects;

    };

    };





protected:

private:

                        BpBinder(int32_t handle,int32_t trackedUid);

                        BpBinder(int32_t handle,int32_t trackedUid);

    virtual             ~BpBinder();

    virtual             ~BpBinder();

    virtual void        onFirstRef();

    virtual void        onFirstRef();

    virtual void        onLastStrongRef(const void* id);

    virtual void        onLastStrongRef(const void* id);

    virtual bool        onIncStrongAttempted(uint32_t flags, const void* id);

    virtual bool        onIncStrongAttempted(uint32_t flags, const void* id);





private:



    friend ::android::internal::Stability;

    friend ::android::internal::Stability;

            int32_t             mStability;

            int32_t             mStability;