Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04dcca83 authored by Chia-I Wu's avatar Chia-I Wu
Browse files

surfaceflinger: add more setCrop tests 

Add LayerTransactionTest.
  SetCropBasic
  SetCropEmpty
  SetCropOutOfBounds
  SetCropWithTranslation
  SetCropWithScale
  SetCropWithResize
  SetCropWithNextResize
  SetCropWithNextResizeScaleToWindow

Test: SurfaceFlinger_test
Change-Id: I6191d9fab30bc0ac40f9f4183fce7aba27203c89
parent a56b2043

services/surfaceflinger/tests/Transaction_test.cpp

+157 −0
Original line number Original line Diff line number Diff line
@@ -1165,6 +1165,163 @@ TEST_F(LayerTransactionTest, SetOverrideScalingModeBasic) { 
    }

    }

}

}





TEST_F(LayerTransactionTest, SetCropBasic) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));

    const Rect crop(8, 8, 24, 24);



    Transaction().setCrop(layer, crop).apply();

    auto shot = screenshot();

    shot->expectColor(crop, Color::RED);

    shot->expectBorder(crop, Color::BLACK);

}



TEST_F(LayerTransactionTest, SetCropEmpty) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    {

        SCOPED_TRACE("empty rect");

        Transaction().setCrop(layer, Rect(8, 8, 8, 8)).apply();

        screenshot()->expectColor(Rect(0, 0, 32, 32), Color::RED);

    }



    {

        SCOPED_TRACE("negative rect");

        Transaction().setCrop(layer, Rect(8, 8, 0, 0)).apply();

        screenshot()->expectColor(Rect(0, 0, 32, 32), Color::RED);

    }

}



TEST_F(LayerTransactionTest, SetCropOutOfBounds) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    Transaction().setCrop(layer, Rect(-128, -64, 128, 64)).apply();

    auto shot = screenshot();

    shot->expectColor(Rect(0, 0, 32, 32), Color::RED);

    shot->expectBorder(Rect(0, 0, 32, 32), Color::BLACK);

}



TEST_F(LayerTransactionTest, SetCropWithTranslation) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    const Point position(32, 32);

    const Rect crop(8, 8, 24, 24);

    Transaction().setPosition(layer, position.x, position.y).setCrop(layer, crop).apply();

    auto shot = screenshot();

    shot->expectColor(crop + position, Color::RED);

    shot->expectBorder(crop + position, Color::BLACK);

}



TEST_F(LayerTransactionTest, SetCropWithScale) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    // crop is affected by matrix

    Transaction()

            .setMatrix(layer, 2.0f, 0.0f, 0.0f, 2.0f)

            .setCrop(layer, Rect(8, 8, 24, 24))

            .apply();

    auto shot = screenshot();

    shot->expectColor(Rect(16, 16, 48, 48), Color::RED);

    shot->expectBorder(Rect(16, 16, 48, 48), Color::BLACK);

}



TEST_F(LayerTransactionTest, SetCropWithResize) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    // setCrop is applied immediately by default, with or without resize pending

    Transaction().setCrop(layer, Rect(8, 8, 24, 24)).setSize(layer, 16, 16).apply();

    {

        SCOPED_TRACE("resize pending");

        auto shot = screenshot();

        shot->expectColor(Rect(8, 8, 24, 24), Color::RED);

        shot->expectBorder(Rect(8, 8, 24, 24), Color::BLACK);

    }



    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));

    {

        SCOPED_TRACE("resize applied");

        auto shot = screenshot();

        shot->expectColor(Rect(8, 8, 16, 16), Color::RED);

        shot->expectBorder(Rect(8, 8, 16, 16), Color::BLACK);

    }

}



TEST_F(LayerTransactionTest, SetCropWithNextResize) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    // request setCrop to be applied with the next resize

    Transaction().setCrop(layer, Rect(8, 8, 24, 24)).setGeometryAppliesWithResize(layer).apply();

    {

        SCOPED_TRACE("waiting for next resize");

        screenshot()->expectColor(Rect(0, 0, 32, 32), Color::RED);

    }



    Transaction().setCrop(layer, Rect(4, 4, 12, 12)).apply();

    {

        SCOPED_TRACE("pending crop modified");

        screenshot()->expectColor(Rect(0, 0, 32, 32), Color::RED);

    }



    Transaction().setSize(layer, 16, 16).apply();

    {

        SCOPED_TRACE("resize pending");

        screenshot()->expectColor(Rect(0, 0, 32, 32), Color::RED);

    }



    // finally resize

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));

    {

        SCOPED_TRACE("new crop applied");

        auto shot = screenshot();

        shot->expectColor(Rect(4, 4, 12, 12), Color::RED);

        shot->expectBorder(Rect(4, 4, 12, 12), Color::BLACK);

    }

}



TEST_F(LayerTransactionTest, SetCropWithNextResizeScaleToWindow) {

    sp<SurfaceControl> layer;

    ASSERT_NO_FATAL_FAILURE(layer = createLayer("test", 32, 32));

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));



    // setCrop is not immediate even with SCALE_TO_WINDOW override

    Transaction()

            .setCrop(layer, Rect(4, 4, 12, 12))

            .setSize(layer, 16, 16)

            .setOverrideScalingMode(layer, NATIVE_WINDOW_SCALING_MODE_SCALE_TO_WINDOW)

            .setGeometryAppliesWithResize(layer)

            .apply();

    {

        SCOPED_TRACE("new crop pending");

        auto shot = screenshot();

        shot->expectColor(Rect(0, 0, 16, 16), Color::RED);

        shot->expectBorder(Rect(0, 0, 16, 16), Color::BLACK);

    }



    // XXX crop is never latched without other geometry change (b/69315677)

    Transaction().setPosition(layer, 1, 0).setGeometryAppliesWithResize(layer).apply();

    ASSERT_NO_FATAL_FAILURE(fillLayerColor(layer, Color::RED));

    Transaction().setPosition(layer, 0, 0).apply();

    {

        SCOPED_TRACE("new crop applied");

        auto shot = screenshot();

        shot->expectColor(Rect(4, 4, 12, 12), Color::RED);

        shot->expectBorder(Rect(4, 4, 12, 12), Color::BLACK);

    }

}



class LayerUpdateTest : public ::testing::Test {

class LayerUpdateTest : public ::testing::Test {

protected:

protected:

    virtual void SetUp() {

    virtual void SetUp() {