Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 02359977 authored by Pawan Wagh's avatar Pawan Wagh
Browse files

Refactored binderRecordReplayTest 

Added generic test class which can be used to expand tests
to different AIDL supported types

Test: m binderRecordReplayTest && adb sync data && adb shell /data/nativetest64/binderRecordReplayTest/binderRecordReplayTest
Bug: 279646634
Change-Id: Ib736cc16acdffb12785fcf4d77b602eb4c2b7e0a
parent bc9f2a6c

libs/binder/tests/binderRecordReplayTest.cpp

+66 −45
Original line number Diff line number Diff line
@@ -48,32 +48,44 @@ private: 
    int mInt = 0;

};



TEST(BinderClearBuf, RecordReplayRepeatInt) {

class BinderClearBuf : public ::testing::Test {

public:

    void SetUp() override {

        // get the remote service

    sp<IBinder> binder = defaultServiceManager()->getService(kServerName);

    ASSERT_NE(nullptr, binder);

    sp<IBinderRecordReplayTest> iface = interface_cast<IBinderRecordReplayTest>(binder);

    sp<BpBinder> bpBinder = binder->remoteBinder();

    ASSERT_NE(nullptr, bpBinder);



    base::unique_fd fd(

            open("/data/local/tmp/binderRecordReplayTest.rec", O_RDWR | O_CREAT | O_CLOEXEC, 0666));

        mBinder = defaultServiceManager()->getService(kServerName);

        ASSERT_NE(nullptr, mBinder);

        mInterface = interface_cast<IBinderRecordReplayTest>(mBinder);

        mBpBinder = mBinder->remoteBinder();

        ASSERT_NE(nullptr, mBpBinder);

    }



    template <typename T>

    void DoTest(Status (IBinderRecordReplayTest::*set)(T), T recordedValue,

                Status (IBinderRecordReplayTest::*get)(T*), T changedValue) {

        base::unique_fd fd(open("/data/local/tmp/binderRecordReplayTest.rec",

                                O_RDWR | O_CREAT | O_CLOEXEC, 0666));

        ASSERT_TRUE(fd.ok());



        // record a transaction

    bpBinder->startRecordingBinder(fd);

    EXPECT_TRUE(iface->setInt(3).isOk());

    bpBinder->stopRecordingBinder();

        mBpBinder->startRecordingBinder(fd);

        auto status = (*mInterface.*set)(recordedValue);

        EXPECT_TRUE(status.isOk());

        mBpBinder->stopRecordingBinder();



        // test transaction does the thing we expect it to do

    int output;

    EXPECT_TRUE(iface->getInt(&output).isOk());

    EXPECT_EQ(output, 3);

        T output;

        status = (*mInterface.*get)(&output);

        EXPECT_TRUE(status.isOk());

        EXPECT_EQ(output, recordedValue);



        // write over the existing state

    EXPECT_TRUE(iface->setInt(5).isOk());

    EXPECT_TRUE(iface->getInt(&output).isOk());

    EXPECT_EQ(output, 5);

        status = (*mInterface.*set)(changedValue);

        EXPECT_TRUE(status.isOk());



        status = (*mInterface.*get)(&output);

        EXPECT_TRUE(status.isOk());



        EXPECT_EQ(output, changedValue);



        // replay transaction

        ASSERT_EQ(0, lseek(fd.get(), 0, SEEK_SET));
@@ -83,16 +95,25 @@ TEST(BinderClearBuf, RecordReplayRepeatInt) { 
        // TODO: move logic to replay RecordedTransaction into RecordedTransaction

        Parcel data;

        data.setData(transaction->getDataParcel().data(), transaction->getDataParcel().dataSize());

    status_t status = binder->remoteBinder()->transact(transaction->getCode(), data, nullptr,

        auto result = mBinder->remoteBinder()->transact(transaction->getCode(), data, nullptr,

                                                        transaction->getFlags());



        // make sure recording does the thing we expect it to do

    EXPECT_EQ(OK, status);

    EXPECT_TRUE(iface->getInt(&output).isOk());

    EXPECT_EQ(output, 3);

        EXPECT_EQ(OK, result);



        status = (*mInterface.*get)(&output);

        EXPECT_TRUE(status.isOk());

        EXPECT_EQ(output, recordedValue);

    }



private:

    sp<IBinder> mBinder;

    sp<BpBinder> mBpBinder;

    sp<IBinderRecordReplayTest> mInterface;

};



    // TODO: we should also make sure we can convert the recording to a fuzzer

    // corpus entry, and we will be able to replay it in the same way

TEST_F(BinderClearBuf, RecordReplayRepeatInt) {

    DoTest(&IBinderRecordReplayTest::setInt, 3, &IBinderRecordReplayTest::getInt, 5);

}



int main(int argc, char** argv) {