Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 00cb980f authored by Ralph Nathan's avatar Ralph Nathan
Browse files

libbinder: Remove templated binder::Status stream operator. 

The templated binder::Status stream operator doesn't work with gmock
because of ambiguous operator overloading. Limiting the stream operator
to just std::stringstream allows it to be used with gmock.

BUG=28171901
TEST=Compiles with gmock and CameraBinderTests

Change-Id: Ia674b68cbff4911b3f5cc3d8ee57d04a1d6cf6bf
parent ac6335cd

include/binder/Status.h

+2 −5
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ 
#define ANDROID_BINDER_STATUS_H



#include <cstdint>

#include <sstream>



#include <binder/Parcel.h>

#include <utils/String8.h>
@@ -142,11 +143,7 @@ private: 
};  // class Status



// For gtest output logging

template<typename T>

T& operator<< (T& stream, const Status& s) {

    stream << s.toString8().string();

    return stream;

}

std::stringstream& operator<< (std::stringstream& stream, const Status& s);



}  // namespace binder

}  // namespace android

libs/binder/Status.cpp

+5 −0
Original line number Diff line number Diff line
@@ -158,5 +158,10 @@ String8 Status::toString8() const { 
    return ret;

}



std::stringstream& operator<< (std::stringstream& stream, const Status& s) {

    stream << s.toString8().string();

    return stream;

}



}  // namespace binder

}  // namespace android