Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f9571049 authored by Jooyung Han's avatar Jooyung Han
Browse files

libbinder: make ParcelableHolder moveable 

The default impl is enough but previously move ctor was hidden because
of copy ctor.

Without move constructor, ParcelableHolder makes AIDL-generated C++ code
invalid (compilation error) when used with ParcelFileDescriptor (which
is moveable but not copyable intentionally).

Bug: 192197147
Test: m test-piece-6-cpp test-piece-6-ndk
Change-Id: I7154b4960595ee046167fffdd9da2f485b97da0a
parent 07ac6eef

libs/binder/include/binder/ParcelableHolder.h

+1 −0
Original line number Diff line number Diff line
@@ -42,6 +42,7 @@ public: 
        }

        mStability = other.mStability;

    }

    ParcelableHolder(ParcelableHolder&& other) = default;



    status_t writeToParcel(Parcel* parcel) const override;

    status_t readFromParcel(const Parcel* parcel) override;

libs/binder/ndk/include_cpp/android/binder_parcelable_utils.h

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ class AParcelableHolder { 
    AParcelableHolder() = delete;

    explicit AParcelableHolder(parcelable_stability_t stability)

        : mParcel(AParcel_create()), mStability(stability) {}



    AParcelableHolder(AParcelableHolder&& other) = default;

    virtual ~AParcelableHolder() = default;



    binder_status_t writeToParcel(AParcel* parcel) const {